Open Prices: price difference between the application and the server

[g123k]

Hi!

This is not the first time I notice this error:
On the app: 4.6€… then on the server: 4.59€

[monsieurtanuki]

Doesn't seem to be a problem on the server side: I managed to add a 4.6 price in off-dart, and it's still 4.6.

[g123k]

I've finally found the issue: the method _fixPriceDecimals in background_task_price.dart.

If we give it 4.6, it will return 4.59.
What was the goal of this method?

[monsieurtanuki]

I've finally found the issue: the method _fixPriceDecimals in background_task_price.dart.

Good!

If we give it 4.6, it will return 4.59. What was the goal of this method?

The goal is to have a number of decimals that matches the currency's.

[monsieurtanuki]

For the record, in dart 4.6 * 100 == 459.99999999999994 !!!

  double _fixPriceDecimals(final double price) {
    final num power10 = pow(10, currency.decimalNumbers);
    return (price * power10).toInt() / power10;
  }

I'll fix it in off-dart.

[g123k]

In off-dart or the app?
Because we can simplify change it like this:

 final double power10 = pow(10, currency.decimalNumbers).toDouble();
return (price * power10) / power10;

[monsieurtanuki]

In off-dart or the app?

It makes more sense in off-dart.

Because we can simplify change it like this

No it doesn't work: if you don't somehow truncate the value, it's pointless.
We want 4.601€ to be 4.60€, as there are only 2 decimals in euro.