Skip to content

Conversation

@Yoshanuikabundi
Copy link
Contributor

Should fix examples CI

@github-actions
Copy link

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

@github-actions
Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 13957449968
  • Triggering actor: github-actions[bot]
  • Target branch: fix-nagl-examples
  • Deployment branch: _cookbook_data_PR94

@mattwthompson
Copy link
Member

This stems from conda-forge/openff-nagl-feedstock#39 / conda-forge/openff-nagl-feedstock#40

I believe we agreed this would be the best short-term fix, but a long-term fix described in the linked issue would still be valuable

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

@github-actions
Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 13957449968
  • Triggering actor: github-actions[bot]
  • Target branch: fix-nagl-examples
  • Deployment branch: _cookbook_data_PR94
  • Job status: cancelled
  • Notebooks status: N/A

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@github-actions
Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 13957644157
  • Triggering actor: github-actions[bot]
  • Target branch: fix-nagl-examples
  • Deployment branch: _cookbook_data_PR94

@github-actions
Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 13957644157
  • Triggering actor: github-actions[bot]
  • Target branch: fix-nagl-examples
  • Deployment branch: _cookbook_data_PR94
  • Job status: success
  • Notebooks status: 30 / 31 notebooks successfully executed (1 failures ignored)
  • Failing notebooks:

    • [ignored] openforcefield/openff-toolkit/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@mattwthompson
Copy link
Member

I believe openforcefield/openff-toolkit#2032 needs to go into a release - perhaps that's the cause of the CI failures a week or so ago ...

Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but I think this is okay to merge anyway since it's tagged as external?

Am I interpreting the green check mark correctly - that the error is captured and considered okay - ?

https://github.com/openforcefield/openff-docs/actions/runs/13957644157/job/39072554849#step:7:232

@Yoshanuikabundi
Copy link
Contributor Author

Yep! Correct on both points - examples won't be updated until they get into a release, and that notebook is marked as ignored so it'll just not appear on the website. Merging!

@Yoshanuikabundi Yoshanuikabundi merged commit 10903e2 into main Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants