Skip to content

Conversation

@Yoshanuikabundi
Copy link
Contributor

Examples are broken because they pull Toolkit 0.16.7 and openff-units 0.3.0, which are not compatible. Failure mode is extremely unusual; the second Python invocation that calls assign_partial_charges in a new environment or with a fresh ~/.cache/pint folder raises a cryptic error:

ToolkitWrapper around AmberTools version 23.6 <class 'openff.toolkit.utils.exceptions.IncompatibleUnitError'> : Unsupported unit passed to partial_charges setter. Found unit elementary_charge, expected elementary_charge

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 14350414174
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 14350414174
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97
  • Job status: failure
  • Notebooks status: 26 / 31 notebooks successfully executed (1 failures ignored)
  • Failing notebooks:
    • openforcefield/openff-nagl/train-gnn-to-electric-field/train-gnn-to-electric-field.ipynb
    • openforcefield/openff-nagl/train-multi-objective-gnn/train-gnn-notebook.ipynb
    • openforcefield/openff-nagl/train-gnn-notebook/train-gnn-notebook.ipynb
    • openforcefield/openff-nagl/prepare-dataset/prepare-dataset.ipynb
    • [ignored] openforcefield/openff-toolkit/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 14350810252
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 14350810252
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97
  • Job status: failure
  • Notebooks status: 28 / 31 notebooks successfully executed (1 failures ignored)
  • Failing notebooks:
    • openforcefield/openff-nagl/train-gnn-to-electric-field/train-gnn-to-electric-field.ipynb
    • openforcefield/openff-nagl/train-multi-objective-gnn/train-gnn-notebook.ipynb
    • [ignored] openforcefield/openff-toolkit/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@Yoshanuikabundi
Copy link
Contributor Author

/regenerate-cache

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 14352485251
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 14352485251
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97
  • Job status: success
  • Notebooks status: 30 / 31 notebooks successfully executed (1 failures ignored)
  • Failing notebooks:

    • [ignored] openforcefield/openff-toolkit/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@mattwthompson
Copy link
Member

I think that the notebook that's dropped (but not in a release yet)

@mattwthompson mattwthompson marked this pull request as draft April 11, 2025 00:36
@Yoshanuikabundi
Copy link
Contributor Author

Yoshanuikabundi commented Apr 11, 2025

Yep @mattwthompson thats correct. I think this is ready for review! (Or I'm happy to hero merge it)

@Yoshanuikabundi Yoshanuikabundi marked this pull request as ready for review April 11, 2025 07:45
@mattwthompson
Copy link
Member

/regenerate-cache

@github-actions
Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 14403863514
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97

@github-actions
Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 14403863514
  • Triggering actor: github-actions[bot]
  • Target branch: offtk-0168
  • Deployment branch: _cookbook_data_PR97
  • Job status: success
  • Notebooks status: 30 / 31 notebooks successfully executed (1 failures ignored)
  • Failing notebooks:

    • [ignored] openforcefield/openff-toolkit/external/swap_amber_parameters/swap_existing_ligand_parameters.ipynb

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@mattwthompson
Copy link
Member

I'm neutral on doing this before a toolkit release

@Yoshanuikabundi Yoshanuikabundi merged commit 5a42c72 into main Apr 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants