Skip to content

Conversation

@mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Apr 11, 2025

Resolves #95 when it works

I mostly looked at where projects are listed and copied stuff over

I think somebody (probably only @lilyminium can) needs to shuffle some perms so this shows up on our docs. subdomain. I haven't done this but maybe @Yoshanuikabundi has written up the process somewhere

@github-actions
Copy link

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@mattwthompson
Copy link
Member Author

The lint action is failing because it can't find a URL that doesn't exist

(           index: line   45) broken    https://docs.openforcefield.org/projects/nagl-models - 404 Client Error: Not Found for url: https://docs.openforcefield.org/projects/nagl-models

@Yoshanuikabundi
Copy link
Contributor

The process for adding it to our docs subdomain is documented here: https://github.com/openforcefield/openff-docs?tab=readme-ov-file#linking-to-new-projects. The essential step is to add it as a sub project of the openff-docs project on RTD, but you need to be a maintainer of both projects to do this. I've sent an invite to @lilyminium to become a maintainer of openff-docs.

@lilyminium
Copy link
Contributor

Thanks Josh, adding it now.

FYI, RTD tells me that The $rest wildcard has been removed in favor of *.

Copy link
Contributor

@Yoshanuikabundi Yoshanuikabundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwthompson mattwthompson marked this pull request as ready for review June 12, 2025 18:23
@mattwthompson mattwthompson reopened this Jun 12, 2025
@github-actions
Copy link

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@mattwthompson
Copy link
Member Author

@mattwthompson mattwthompson merged commit 18c4da4 into main Jun 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NAGL models repo?

4 participants