Skip to content

Commit 67987d8

Browse files
authored
Android x86_64 emulator fixes. NDK to 28.2. SDK to 36 (#543)
* Android x86_64 emulator fixes. NDK to 28.2. SDK to 36 (cherry picked from commit 73830bfdee35d945af5af7161d943b3e4d4c3924) * Android Target
1 parent f37f06f commit 67987d8

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

.github/workflows/build-android.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ jobs:
4242
strategy:
4343
matrix:
4444
ARCH: [armv7, arm64, x86_64]
45-
SDK: ["35.0.0"]
46-
NDK: ["28.0.13004108"]
45+
SDK: ["36.0.0"]
46+
NDK: ["28.2.13676358"]
4747
API: ["24"]
4848
env:
4949
ARCH: ${{ matrix.ARCH }}

apothecary/configure/android_configure.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export TOOLCHAIN_ROOT="${APOTHECARY_LEVEL}/android"
2222

2323
if [ "${NDK:-}" == "27.2.12479018" ]; then
2424
export NDK_ROOT="${ANDROID_NDK_ROOT:-}"
25-
elif [ "${NDK:-}" == "28.0.13004108" ]; then
25+
elif [ "${NDK:-}" == "28.2.13676358" ]; then
2626
if [ -n "${ANDROID_NDK_LATEST_HOME:-}" ]; then
2727
export ANDROID_NDK_ROOT="${ANDROID_NDK_LATEST_HOME}"
2828
fi

apothecary/toolchains/android.toolchain.cmake

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,29 +79,29 @@ if(ANDROID_ABI STREQUAL "armeabi-v7a")
7979
set(CMAKE_ANDROID_ARM_MODE ON)
8080
set(CMAKE_ANDROID_ARM_NEON ON)
8181
set(CMAKE_SYSTEM_PROCESSOR "armv7-a")
82-
set(CMAKE_C_FLAGS "-mfpu=neon -mfloat-abi=softfp -O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET}")
83-
set(CMAKE_CXX_FLAGS "-mfpu=neon -mfloat-abi=softfp -O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET}")
82+
set(CMAKE_C_FLAGS "-mfpu=neon -mfloat-abi=softfp -O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
83+
set(CMAKE_CXX_FLAGS "-mfpu=neon -mfloat-abi=softfp -O3 -ffast-math -funroll-loops -funsafe-math-optimizations -fexceptions -frtti --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
8484
elseif(ANDROID_ABI STREQUAL "arm64-v8a")
8585
set(MACHINE "arm64")
8686
set(ANDROID_PREFIX "aarch64-linux-android")
8787
set(ANDROID_TARGET "aarch64-none-linux-android${ANDROID_NATIVE_API_LEVEL}")
8888
set(CMAKE_SYSTEM_PROCESSOR "aarch64")
89-
set(CMAKE_C_FLAGS "-O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET}")
90-
set(CMAKE_CXX_FLAGS "-O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET}")
89+
set(CMAKE_C_FLAGS "-O3 -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
90+
set(CMAKE_CXX_FLAGS "-O3 -fexceptions -frtti -ffast-math -funroll-loops -funsafe-math-optimizations --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
9191
elseif(ANDROID_ABI STREQUAL "x86")
9292
set(MACHINE "i686")
9393
set(ANDROID_PREFIX "i686-linux-android")
9494
set(ANDROID_TARGET "i686-none-linux-android${ANDROID_NATIVE_API_LEVEL}")
9595
set(CMAKE_SYSTEM_PROCESSOR "i686")
96-
set(CMAKE_C_FLAGS "-msse4.2 -mavx -O3 -ffast-math -funroll-loops")
97-
set(CMAKE_CXX_FLAGS "-msse4.2 -mavx -O3 -ffast-math -funroll-loops")
96+
set(CMAKE_C_FLAGS "-O3 --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
97+
set(CMAKE_CXX_FLAGS "-O3 -fexceptions -frtti --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
9898
elseif(ANDROID_ABI STREQUAL "x86_64")
9999
set(MACHINE "x86_64")
100100
set(ANDROID_PREFIX "x86_64-linux-android")
101101
set(ANDROID_TARGET "x86_64-none-linux-android${ANDROID_NATIVE_API_LEVEL}")
102102
set(CMAKE_SYSTEM_PROCESSOR "x86_64")
103-
set(CMAKE_C_FLAGS "-msse4.2 -mavx -O3 -ffast-math -funroll-loops --target=${ANDROID_TARGET}")
104-
set(CMAKE_CXX_FLAGS "-msse4.2 -mavx -O3 -ffast-math -funroll-loops --target=${ANDROID_TARGET}")
103+
set(CMAKE_C_FLAGS "-O3 --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
104+
set(CMAKE_CXX_FLAGS "-O3 -fexceptions -frtti --target=${ANDROID_TARGET} -D__ANDROID_API__=${ANDROID_API}")
105105
else()
106106
message(FATAL_ERROR "Unsupported ANDROID_ABI: ${ANDROID_ABI}")
107107
endif()

0 commit comments

Comments
 (0)