Skip to content

Commit 4c9cec3

Browse files
committed
Merge commit '74993cc682b08b20c1c22336ebc385df7a3d7ac3' into linux2025
* commit '74993cc682b08b20c1c22336ebc385df7a3d7ac3': Bugfix assimp addons (#8288) Update ofRtAudioSoundStream.cpp Update config.emscripten.default.mk Code sign app (#8285)
2 parents 858fe0f + 74993cc commit 4c9cec3

File tree

6 files changed

+22
-8
lines changed

6 files changed

+22
-8
lines changed

addons/ofxAssimp/addon_config.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,4 +104,4 @@ android/x86:
104104

105105
emscripten:
106106
ADDON_LIBS=
107-
ADDON_LIBS=../ofxAssimpModelLoader/libs/assimp/lib/emscripten/libassimp.a
107+
ADDON_LIBS=../ofxAssimpModelLoader/libs/assimp/lib/emscripten/%/libassimp.a

addons/ofxAssimpModelLoader/addon_config.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,4 @@ osx:
107107

108108
emscripten:
109109
ADDON_LIBS=
110-
ADDON_LIBS=libs/assimp/lib/emscripten/libassimp.a
110+
ADDON_LIBS=libs/assimp/lib/emscripten/%/libassimp.a

libs/openFrameworks/sound/ofRtAudioSoundStream.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,8 @@ bool ofRtAudioSoundStream::setup(const ofSoundStreamSettings & settings_)
146146
ofLogNotice() << "Initialing RtAudio with UNSPECIFIED API";
147147
audio = std::make_shared<RtAudio>();
148148
}
149-
ofLogNotice() << "Initialized RtAudio with API: " << RtAudio::getApiName(audio->getCurrentApi());
149+
//needs latest RtAudio - this breaks in slightly older linux
150+
//ofLogNotice() << "Initialized RtAudio with API: " << RtAudio::getApiName(audio->getCurrentApi());
150151
}
151152
catch (std::exception &error) {
152153
ofLogError() << "Failed to initialize RtAudio: " << error.what();

libs/openFrameworksCompiled/project/emscripten/config.emscripten.default.mk

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,10 @@ PLATFORM_LDFLAGS += -s DYNAMIC_EXECUTION=0 -s EMBIND_AOT=1
142142
PLATFORM_LDFLAGS += -s USE_GLFW=3 -lglfw
143143
# PLATFORM_LDFLAGS += -sEXPORTED_FUNCTIONS=all
144144
#PLATFORM_LDFLAGS += -sEXPORTED_FUNCTIONS='["_main", "_malloc", "_free"]'
145-
PLATFORM_LDFLAGS += -sERROR_ON_UNDEFINED_SYMBOLS=0
145+
146+
#Do not change this!
147+
#If there are errors we need to see them!
148+
PLATFORM_LDFLAGS += -sERROR_ON_UNDEFINED_SYMBOLS=1
146149

147150
#PLATFORM_LDFLAGS += -s AUDIO_WORKLET=1 -s WASM_WORKERS=1 -sENVIRONMENT="web,worker" -s WEBAUDIO_DEBUG=1
148151

libs/openFrameworksCompiled/project/makefileCommon/config.addons.mk

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,14 @@ define parse_addon
149149
$(eval TMP_PROJECT_ADDONS_CFLAGS += $(ADDON_CPPFLAGS)) \
150150
$(if $(strip $(ADDON_LIBS)), \
151151
$(foreach addon_lib, $(strip $(ADDON_LIBS)), \
152-
$(if $(wildcard $(addon)/$(addon_lib)), \
153-
$(eval TMP_PROJECT_ADDONS_LIBS += $(addon)/$(addon_lib)) \
152+
$(eval lib_pattern := $(subst %,*,$(addon_lib))) \
153+
$(eval match := $(wildcard $(addon)/$(lib_pattern))) \
154+
$(if $(match), \
155+
$(eval TMP_PROJECT_ADDONS_LIBS += $(match)) \
154156
) \
155-
$(if $(wildcard $(addon_lib)), \
156-
$(eval TMP_PROJECT_ADDONS_LIBS += $(addon_lib)) \
157+
$(eval match_global := $(wildcard $(lib_pattern))) \
158+
$(if $(match_global), \
159+
$(eval TMP_PROJECT_ADDONS_LIBS += $(match_global)) \
157160
) \
158161
) \
159162
) \

scripts/osx/xcode_project.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,13 @@ copy_binary() {
230230
echo "ERROR: Failed to copy the app"
231231
exit 1
232232
fi
233+
234+
if [ -z "${CODE_SIGN_IDENTITY}" ]; then
235+
echo "No CODE_SIGN_IDENTITY set. Unable to sign the app."
236+
exit 0
237+
fi
238+
echo "Current CODE_SIGN_IDENTITY: '${CODE_SIGN_IDENTITY}'"
239+
codesign --force --sign "${CODE_SIGN_IDENTITY}" "${APP_DEST}/${APP_NAME}"
233240
}
234241

235242
echo ''

0 commit comments

Comments
 (0)