Skip to content

Commit f3cba55

Browse files
committed
🐛(api) fix lti roles model
Update LTI roles model to handle additional roles from Moodle LTI launch requests, not covered by LTIRoles
1 parent 2c0327e commit f3cba55

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

src/api/core/warren/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from datetime import datetime
44
from functools import reduce
55
from itertools import groupby
6-
from typing import Any, Dict, List, Optional, Set
6+
from typing import Any, Dict, List, Optional, Set, Union
77

88
import arrow
99
from lti_toolbox.launch_params import LTIRole
@@ -255,7 +255,7 @@ class LTIToken(BaseModel):
255255
session_id: str
256256
consumer_site: str
257257
course_id: str
258-
roles: List[LTIRole]
258+
roles: List[Union[LTIRole, str]]
259259
user: LTIUser
260260
locale: str
261261
resource_link_id: str

src/api/core/warren/tests/test_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def test_get_lti_token():
6262
"iat": timestamp,
6363
"jti": "",
6464
"session_id": str(uuid.uuid4()),
65-
"roles": ["instructor"],
65+
"roles": ["instructor", "urn:lti:sysrole:ims/lis/Administrator"],
6666
"user": lti_user,
6767
"consumer_site": "http://fake-lms.com",
6868
"course_id": "course-v1:openfun+mathematics101+session01",

src/frontend/yarn.lock

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4715,6 +4715,11 @@ jsonify@^0.0.1:
47154715
object.assign "^4.1.4"
47164716
object.values "^1.1.6"
47174717

4718+
jwt-decode@4.0.0:
4719+
version "4.0.0"
4720+
resolved "https://registry.yarnpkg.com/jwt-decode/-/jwt-decode-4.0.0.tgz#2270352425fd413785b2faf11f6e755c5151bd4b"
4721+
integrity sha512-+KJGIyHgkGuIq3IEBNftfhW/LfWhXUIY6OmyVWjliu5KH1y0fw7VQ8YndE2O4qZdMSd9SqbnC8GOcZEy0Om7sA==
4722+
47184723
kind-of@^6.0.3:
47194724
version "6.0.3"
47204725
resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-6.0.3.tgz#07c05034a6c349fa06e24fa35aa76db4580ce4dd"

0 commit comments

Comments
 (0)