Fix accessing deleted network reply pointer

Author: nirvn

src/core/qfieldcloudprojectsmodel.cpp

@@ -932,12 +932,14 @@ void QFieldCloudProjectsModel::projectPackageAndDownload( const QString &project
     const QStringList fileNames = project->downloadFileTransfers.keys();
     for ( const QString &fileNameKey : fileNames )
     {
-      if ( project->downloadFileTransfers[fileNameKey].networkReply
-           && !project->downloadFileTransfers[fileNameKey].networkReply->isFinished() )
+      if ( project->downloadFileTransfers[fileNameKey].networkReply )
       {
-        project->downloadFileTransfers[fileNameKey].networkReply->abort();
+        if ( !project->downloadFileTransfers[fileNameKey].networkReply->isFinished() )
+        {
+          project->downloadFileTransfers[fileNameKey].networkReply->abort();
+        }
+        project->downloadFileTransfers[fileNameKey].networkReply->deleteLater();
       }
-      project->downloadFileTransfers[fileNameKey].networkReply->deleteLater();
     }
 
     mActiveProjectFilesToDownload.clear();

src/core/qfieldcloudprojectsmodel.h

@@ -17,18 +17,19 @@
 #define QFIELDCLOUDPROJECTSMODEL_H
 
 #include "deltalistmodel.h"
+#include "networkreply.h"
 #include "qgsgpkgflusher.h"
 
 #include <QAbstractListModel>
 #include <QJsonArray>
 #include <QNetworkReply>
+#include <QPointer>
 #include <QSortFilterProxyModel>
 #include <QTimer>
 
 
 class QNetworkRequest;
 class QFieldCloudConnection;
-class NetworkReply;
 class LayerObserver;
 class QgsMapLayer;
 class QgsProject;
@@ -341,7 +342,7 @@ class QFieldCloudProjectsModel : public QAbstractListModel
         long long bytesTotal;
         long long bytesTransferred = 0;
         bool isFinished = false;
-        NetworkReply *networkReply;
+        QPointer<NetworkReply> networkReply;
         QNetworkReply::NetworkError error = QNetworkReply::NoError;
         QStringList layerIds;
         int redirectsCount = 0;