De-duplicate code

nirvn · nirvn · commit e49418435d12 · 2025-03-10T09:29:48.000+07:00
diff --git a/src/core/webdavconnection.cpp b/src/core/webdavconnection.cpp
@@ -446,6 +446,8 @@ void WebdavConnection::getWebdavItems()
 
 void WebdavConnection::forgetHistory( const QString &url, const QString &username )
 {
+  QgsAuthManager *authManager = QgsApplication::instance()->authManager();
+  QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();
   QSettings settings;
   if ( !username.isEmpty() )
   {
@@ -455,8 +457,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam
     settings.remove( "" );
     settings.endGroup();
 
-    QgsAuthManager *authManager = QgsApplication::instance()->authManager();
-    QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();
     for ( QgsAuthMethodConfig &config : configs )
     {
       if ( config.uri() == url )
@@ -475,8 +475,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam
     settings.remove( "" );
     settings.endGroup();
 
-    QgsAuthManager *authManager = QgsApplication::instance()->authManager();
-    QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();
     for ( QgsAuthMethodConfig &config : configs )
     {
       if ( config.uri() == url )
@@ -492,8 +490,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam
     settings.remove( "" );
     settings.endGroup();
 
-    QgsAuthManager *authManager = QgsApplication::instance()->authManager();
-    QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();
     for ( QgsAuthMethodConfig &config : configs )
     {
       if ( urls.contains( config.uri() ) )

Original file line number	Diff line number	Diff line change
`@@ -446,6 +446,8 @@ void WebdavConnection::getWebdavItems()`
`446`	`446`
`447`	`447`	`void WebdavConnection::forgetHistory( const QString &url, const QString &username )`
`448`	`448`	`{`
	`449`	`+ QgsAuthManager *authManager = QgsApplication::instance()->authManager();`
	`450`	`+ QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();`
`449`	`451`	`QSettings settings;`
`450`	`452`	`if ( !username.isEmpty() )`
`451`	`453`	`{`
`@@ -455,8 +457,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam`
`455`	`457`	`settings.remove( "" );`
`456`	`458`	`settings.endGroup();`
`457`	`459`
`458`		`- QgsAuthManager *authManager = QgsApplication::instance()->authManager();`
`459`		`- QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();`
`460`	`460`	`for ( QgsAuthMethodConfig &config : configs )`
`461`	`461`	`{`
`462`	`462`	`if ( config.uri() == url )`
`@@ -475,8 +475,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam`
`475`	`475`	`settings.remove( "" );`
`476`	`476`	`settings.endGroup();`
`477`	`477`
`478`		`- QgsAuthManager *authManager = QgsApplication::instance()->authManager();`
`479`		`- QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();`
`480`	`478`	`for ( QgsAuthMethodConfig &config : configs )`
`481`	`479`	`{`
`482`	`480`	`if ( config.uri() == url )`
`@@ -492,8 +490,6 @@ void WebdavConnection::forgetHistory( const QString &url, const QString &usernam`
`492`	`490`	`settings.remove( "" );`
`493`	`491`	`settings.endGroup();`
`494`	`492`
`495`		`- QgsAuthManager *authManager = QgsApplication::instance()->authManager();`
`496`		`- QgsAuthMethodConfigsMap configs = authManager->availableAuthMethodConfigs();`
`497`	`493`	`for ( QgsAuthMethodConfig &config : configs )`
`498`	`494`	`{`
`499`	`495`	`if ( urls.contains( config.uri() ) )`