Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo care about param (it should not be considered)* Not sure what model file download should be offered. On model adding by Model Baker Plugin it makes sense, that it gathers the URL as well and downloads it. But on e.g. XTF parse, it does not have the model URL, so maybe the function https://github.com/opengisch/QgisModelBakerLibrary/pull/153/files#diff-d2fdd9a0f0e6c13e663c41598dac607c5571830ead68fec357814e006fab4714R100 with all it's attributes (new IliModelFileCache) would make sense. It just seems not performant. This whole cache stuff is a little bit a mess.