Use pyplugin_installer

Author: domi4484

docs/docs/getting_started.md

@@ -84,14 +84,12 @@ In the `Project` tab:
 
 ## Install the module plugin
 
-In the `Plugin` tab, you can install the module plugin (ie. TWW plugin). There are two ways to install the plugin:
+In the `Plugin` tab, you can install the module plugin (ie. TWW plugin). There are two possibilities:
 
-1. Click `Install`
-   * If running oQtopus from QGIS, the plugin is installed in the current QGIS profile.
-   * If running oQtopus standalone, you get asked to select the QGIS profile directory.
+1. Click `Install` and it will be installed in the current QGIS profile. Note: this is possible only if running oQtopus from QGIS.
 2. Click `Copy ZIP to directory`:
    * You can copy the plugin zip file to a directory of your choice.
-   * Then in QGIS > Extension > Install and manage extension > Install from ZIP
+   * Then in QGIS > Extension > Install and manage extension > Install from ZIP.
 
 
 ## oQtopus as a standalone python executable

oqtopus/gui/plugin_widget.py

@@ -1,9 +1,7 @@
 import os
 import shutil
-import tempfile
-import zipfile
 
-from qgis.PyQt.QtCore import QDir, QStandardPaths, QUrl
+from qgis.PyQt.QtCore import QUrl
 from qgis.PyQt.QtGui import QDesktopServices
 from qgis.PyQt.QtWidgets import QFileDialog, QMessageBox, QWidget
 
@@ -84,141 +82,27 @@ def __installClicked(self):
             QtUtils.setFontItalic(self.info_label, True)
             return
 
-        # Determine QGIS user plugins directory (profile/python/plugins)
         try:
-            from qgis.core import QgsApplication
+            from pyplugin_installer import instance as plugin_installer_instance
 
-            qgis_settings_dir = QgsApplication.qgisSettingsDirPath()
-        except Exception:
-            qgis_settings_dir = None
+            installer = plugin_installer_instance()
+            installer.installFromZipFile(asset_plugin.package_zip)
 
-        if not qgis_settings_dir:
-            answer = QMessageBox.question(
-                self,
-                self.tr("Error"),
-                self.tr(
-                    "Can't determine QGIS profile directory automatically. Please open the profile folder or cancel."
-                ),
-                QMessageBox.StandardButton.Open | QMessageBox.StandardButton.Cancel,
-            )
-            if answer == QMessageBox.StandardButton.Cancel:
-                return
-
-            # No qgis classes available: look into usual Qt settings folder
-            qgis_app_dir = QStandardPaths.locate(
-                QStandardPaths.StandardLocation.GenericDataLocation,
-                "QGIS/QGIS3/profiles",
-                QStandardPaths.LocateOption.LocateDirectory,
-            )
-
-            qgis_settings_dir = QFileDialog.getExistingDirectory(
-                self,
-                self.tr("Open QGIS Profile Folder"),
-                qgis_app_dir,
-            )
-            if not qgis_settings_dir:
-                return
-
-        plugins_dir = os.path.join(qgis_settings_dir, "python", "plugins")
-
-        # Ensure plugins directory exists (create if necessary)
-        try:
-            os.makedirs(plugins_dir, exist_ok=True)
-        except Exception as e:
-            QMessageBox.critical(
-                self,
-                self.tr("Error"),
-                self.tr(f"Can't create plugins directory '{plugins_dir}': {e}"),
-            )
             return
 
-        # Extract zip to a temporary directory and move to plugins folder
-        try:
-            with tempfile.TemporaryDirectory() as tmpdir:
-                with zipfile.ZipFile(asset_plugin.package_zip, "r") as zf:
-                    zf.extractall(tmpdir)
-
-                # Inspect top-level entries
-                qdir = QDir(tmpdir)
-                entries_info = qdir.entryInfoList(QDir.Filter.NoDotAndDotDot | QDir.Filter.Dirs)
-                # Require exactly one top-level directory (well-formed plugin zip)
-                if len(entries_info) != 1:
-                    QMessageBox.critical(
-                        self,
-                        self.tr("Invalid plugin package"),
-                        self.tr(
-                            "The plugin zip must contain exactly one top-level directory. "
-                            "Please provide a properly packaged plugin."
-                        ),
-                    )
-                    return
-
-                dest_name = entries_info[0].fileName()
-                src_path = os.path.join(tmpdir, dest_name)
-                dest_path = os.path.join(plugins_dir, dest_name)
-
-                # If destination exists, ask user whether to overwrite
-                if os.path.exists(dest_path):
-                    res = QMessageBox.question(
-                        self,
-                        self.tr("Overwrite plugin"),
-                        self.tr(
-                            f"The plugin '{dest_name}' already exists in the QGIS plugins folder. Overwrite?"
-                        ),
-                        QMessageBox.StandardButton.Yes | QMessageBox.StandardButton.No,
-                    )
-                    if res != QMessageBox.StandardButton.Yes:
-                        return
-                    # Remove existing plugin directory
-                    try:
-                        if os.path.islink(dest_path) or os.path.isfile(dest_path):
-                            os.remove(dest_path)
-                        else:
-                            shutil.rmtree(dest_path)
-                    except Exception as e:
-                        QMessageBox.critical(
-                            self,
-                            self.tr("Error"),
-                            self.tr(f"Failed to remove existing plugin '{dest_path}': {e}"),
-                        )
-                        return
-
-                # Move the extracted plugin into plugins directory
-                try:
-                    shutil.move(src_path, dest_path)
-                except Exception:
-                    # If move fails (cross-device), fallback to copytree
-                    try:
-                        shutil.copytree(src_path, dest_path)
-                    except Exception as e2:
-                        QMessageBox.critical(
-                            self,
-                            self.tr("Error"),
-                            self.tr(f"Failed to install plugin to '{dest_path}': {e2}"),
-                        )
-                        return
-
-            QMessageBox.information(
-                self,
-                self.tr("Plugin installed"),
-                self.tr(
-                    f"Plugin '{dest_name}' installed to QGIS profile plugins folder:\n{dest_path}\n\nYou may need to restart QGIS or enable the plugin from the Plugin Manager."
-                ),
-            )
-
-        except zipfile.BadZipFile:
-            QMessageBox.critical(
+        except ImportError:
+            QMessageBox.warning(
                 self,
                 self.tr("Error"),
-                self.tr("The plugin package is not a valid zip archive."),
+                self.tr("Plugin installation is not possible when oQtopus is running standalone."),
             )
             return
+
         except Exception as e:
-            logger.exception("Unexpected error during plugin installation")
-            QMessageBox.critical(
+            QMessageBox.warning(
                 self,
                 self.tr("Error"),
-                self.tr(f"Failed to install plugin: {e}"),
+                self.tr("Plugin installation failed with an exception: {0}").format(str(e)),
             )
             return