Skip to content

Commit 6d47965

Browse files
committed
fix metadata + load dev after zip
1 parent e2a2d15 commit 6d47965

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

oqtopus/core/module_package.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ def __init__(
3939
self.asset_project = None
4040
self.asset_plugin = None
4141

42+
self.source_package_zip = None
43+
self.source_package_dir = None
44+
4245
if self.type == ModulePackage.Type.RELEASE:
4346
self.__parse_release(json_payload)
4447
elif self.type == ModulePackage.Type.BRANCH:
@@ -56,9 +59,6 @@ def __init__(
5659

5760
self.download_url = f"https://github.com/{self.organisation}/{self.repository}/archive/refs/{type}/{self.branch}.zip"
5861

59-
self.source_package_zip = None
60-
self.source_package_dir = None
61-
6262
def display_name(self):
6363
if self.prerelease:
6464
return f"{self.name} (prerelease)"

oqtopus/gui/module_selection_widget.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,13 +250,13 @@ def __loadModuleFromZip(self, filename):
250250
def __packagePrepareTaskFinished(self):
251251
logger.info("Load package task finished")
252252

253-
self.signal_loadingFinished.emit()
254253
self.module_progressBar.setVisible(False)
255254

256255
if isinstance(self.__packagePrepareTask.lastError, PackagePrepareTaskCanceled):
257256
logger.info("Load package task was canceled by user.")
258257
self.module_information_label.setText(self.tr("Package loading canceled."))
259258
QtUtils.setForegroundColor(self.module_information_label, PluginUtils.COLOR_WARNING)
259+
# Don't emit signal_loadingFinished when cancelled - a new load may be starting
260260
return
261261

262262
if self.__packagePrepareTask.lastError is not None:
@@ -266,8 +266,11 @@ def __packagePrepareTaskFinished(self):
266266
).exec()
267267
self.module_information_label.setText(error_text)
268268
QtUtils.setForegroundColor(self.module_information_label, PluginUtils.COLOR_WARNING)
269+
self.signal_loadingFinished.emit()
269270
return
270271

272+
self.signal_loadingFinished.emit()
273+
271274
package_dir = self.module_package_comboBox.currentData().source_package_dir
272275
logger.info(f"Package loaded into '{package_dir}'")
273276
QtUtils.resetForegroundColor(self.module_information_label)
@@ -418,9 +421,14 @@ def __loadDevelopmentVersionsFinished(self, error):
418421
logger.info("Loading development versions finished")
419422

420423
QApplication.restoreOverrideCursor()
421-
self.signal_loadingFinished.emit()
422424
self.module_progressBar.setVisible(False)
423425

426+
# Hide zip widget when loading development versions
427+
self.module_zipPackage_groupBox.setVisible(False)
428+
429+
# Clear current module package - user needs to select a specific version
430+
self.__current_module_package = None
431+
424432
if error:
425433
if "rate limit exceeded for url" in error.lower():
426434
QMessageBox.critical(

oqtopus/metadata.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,3 @@ icon=icons/oqtopus-logo.png
2020
experimental=True
2121
deprecated=False
2222
server=False
23-
24-
supportsQt6=True

0 commit comments

Comments
 (0)