do not upgrade if beta_testing

Author: 3nids

docs/docs/cli.md

@@ -1,10 +1,11 @@
-usage: pum [-h] [-c CONFIG_FILE] -p PG_CONNECTION [-d DIR] [-v] [--version] {info,install,upgrade,role,check,dump,restore,baseline} ...
+usage: pum [-h] [-c CONFIG_FILE] -p PG_CONNECTION [-d DIR] [-v] [-q] [--version] {info,install,upgrade,role,check,dump,restore,baseline} ...
 ### options:
 - `-h, --help`: show this help message and exit
 - `-c CONFIG_FILE, --config_file CONFIG_FILE`: set the config file. Default: .pum.yaml
 - `-p PG_CONNECTION, --pg-connection PG_CONNECTION`: PostgreSQL service name or connection string (e.g., 'mydb' or 'postgresql://user:pass@host/db')
 - `-d DIR, --dir DIR`: Directory or URL of the module. Default: .
-- `-v, --verbose`: Increase output verbosity (e.g. -v, -vv)
+- `-v, --verbose`: Increase verbosity (-v for DEBUG, -vv for SQL statements)
+- `-q, --quiet`: Suppress info messages, only show warnings and errors
 - `--version`: Show program's version number and exit.
 ### commands:
 valid pum commands

docs/docs/cli/upgrade.md

@@ -1,9 +1,10 @@
-usage: pum upgrade [-h] [-p PARAMETER PARAMETER] [-u MAX_VERSION] [--skip-grant] [--beta-testing] [--skip-drop-app] [--skip-create-app]
+usage: pum upgrade [-h] [-p PARAMETER PARAMETER] [-u MAX_VERSION] [--skip-grant] [--beta-testing] [--force] [--skip-drop-app] [--skip-create-app]
 ### options:
 - `-h, --help`: show this help message and exit
 - `-p PARAMETER PARAMETER, --parameter PARAMETER PARAMETER`: Assign variable for running SQL deltas. Format is name value.
 - `-u MAX_VERSION, --max-version MAX_VERSION`: maximum version to upgrade
 - `--skip-grant`: Skip granting permissions to roles
 - `--beta-testing`: Install in beta testing mode.
+- `--force`: Allow upgrading a module installed in beta testing mode.
 - `--skip-drop-app`: Skip drop app handlers during upgrade.
 - `--skip-create-app`: Skip create app handlers during upgrade.

pum/cli.py

@@ -210,6 +210,11 @@ def formatter_class(prog):
     parser_upgrade.add_argument(
         "--beta-testing", help="Install in beta testing mode.", action="store_true"
     )
+    parser_upgrade.add_argument(
+        "--force",
+        help="Allow upgrading a module installed in beta testing mode.",
+        action="store_true",
+    )
     parser_upgrade.add_argument(
         "--skip-drop-app",
         help="Skip drop app handlers during upgrade.",
@@ -466,6 +471,7 @@ def cli() -> int:  # noqa: PLR0912
                 max_version=args.max_version,
                 grant=not args.skip_grant,
                 beta_testing=args.beta_testing,
+                force=args.force,
                 skip_drop_app=args.skip_drop_app,
                 skip_create_app=args.skip_create_app,
             )

pum/upgrader.py

@@ -193,6 +193,7 @@ def upgrade(
         parameters: dict | None = None,
         max_version: str | packaging.version.Version | None = None,
         beta_testing: bool = False,
+        force: bool = False,
         skip_drop_app: bool = False,
         skip_create_app: bool = False,
         grant: bool = True,
@@ -211,6 +212,8 @@ def upgrade(
                 If True, the module is upgraded in beta testing mode.
                 This means that the module will not be allowed to receive any future updates.
                 We strongly discourage using this for production.
+            force:
+                If True, allow upgrading a module that is installed in beta testing mode.
             skip_drop_app:
                 If True, drop app handlers will be skipped.
             skip_create_app:
@@ -225,6 +228,17 @@ def upgrade(
             )
             raise PumException(msg)
 
+        migration_details = self.schema_migrations.migration_details(connection)
+        installed_beta_testing = bool(migration_details.get("beta_testing", False))
+        if installed_beta_testing and not force:
+            msg = (
+                "This module is installed in beta testing mode, upgrades are disabled. "
+                "Re-run with force=True (or --force in the CLI) if you really want to upgrade anyway."
+            )
+            raise PumException(msg)
+
+        effective_beta_testing = beta_testing or installed_beta_testing
+
         logger.info("Starting upgrade process...")
 
         if not skip_drop_app:
@@ -251,7 +265,7 @@ def upgrade(
                 commit=False,
                 parameters=parameters,
                 schema_migrations=self.schema_migrations,
-                beta_testing=beta_testing,
+                beta_testing=effective_beta_testing,
             )
 
         if not skip_create_app:

test/test_upgrader.py

@@ -473,6 +473,28 @@ def test_upgrade(self) -> None:
             upgrader.upgrade(connection=conn)
             self.assertEqual(sm.baseline(conn), Version("2.0.0"))
 
+    def test_upgrade_blocked_when_installed_beta_testing_unless_forced(self) -> None:
+        """Upgrading a beta-testing installation should be blocked unless forced."""
+        test_dir = Path("test") / "data" / "multiple_changelogs"
+        cfg = PumConfig(test_dir)
+        sm = SchemaMigrations(cfg)
+        with psycopg.connect(f"service={self.pg_service}") as conn:
+            self.assertFalse(sm.exists(conn))
+            upgrader = Upgrader(config=cfg)
+            upgrader.install(connection=conn, max_version="1.2.3", beta_testing=True)
+            self.assertEqual(sm.baseline(conn), Version("1.2.3"))
+            self.assertTrue(sm.migration_details(conn)["beta_testing"])
+
+            with self.assertRaises(PumException):
+                upgrader.upgrade(connection=conn, max_version="1.2.4")
+
+            upgrader.upgrade(connection=conn, max_version="1.2.4", force=True)
+            self.assertEqual(sm.baseline(conn), Version("1.2.4"))
+            self.assertTrue(sm.migration_details(conn)["beta_testing"])
+
+            with self.assertRaises(PumException):
+                upgrader.upgrade(connection=conn, force=False)
+
     def test_upgrade_with_grant(self) -> None:
         """Test that permissions are granted correctly after upgrade."""
         test_dir = Path("test") / "data" / "roles"