Skip to content

Commit a1f8459

Browse files
Arta AsadiArta Asadi
authored andcommitted
fix: remove parameter check on task schedules
1 parent 9496598 commit a1f8459

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

pkg/platformspec/task_spec.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ func (v *defaultValidator) validateTaskStructure(spec *TaskSpecification, isStan
253253
}
254254

255255
// Detailed Run Schedule Entry checks
256-
defaultScheduleFound := false
257256
paramSet := make(map[string]struct{})
258257
for _, p := range spec.Params {
259258
if !isNonEmpty(p) {
@@ -281,23 +280,6 @@ func (v *defaultValidator) validateTaskStructure(spec *TaskSpecification, isStan
281280
if !isNonEmpty(schedule.Frequency) {
282281
return fmt.Errorf("%s: frequency field is required", entryContext)
283282
}
284-
if schedule.ID == "describe-all" || schedule.ID == "default" {
285-
defaultScheduleFound = true
286-
for requiredParam := range paramSet {
287-
if _, ok := schedule.Params[requiredParam]; !ok {
288-
return fmt.Errorf("%s: default schedule missing required parameter '%s'", entryContext, requiredParam)
289-
}
290-
}
291-
} else {
292-
for definedParam := range schedule.Params {
293-
if _, ok := paramSet[definedParam]; !ok {
294-
return fmt.Errorf("%s: defines parameter '%s' not declared in top-level 'params'", entryContext, definedParam)
295-
}
296-
}
297-
}
298-
}
299-
if !defaultScheduleFound && len(paramSet) > 0 {
300-
return fmt.Errorf("%s: task defines parameters but no run_schedule entry with id 'describe-all' or 'default' was found", taskDesc)
301283
}
302284

303285
return nil // All checks passed

0 commit comments

Comments
 (0)