fix: fix resource structure for cluster role binding

Author: Arta Asadi

cloudql/kubernetes/common_column.go

@@ -3,6 +3,8 @@ package kubernetes
 import (
 	"context"
 	"encoding/json"
+	"github.com/shurcooL/githubv4"
+	"time"
 
 	"github.com/turbot/steampipe-plugin-sdk/v5/grpc/proto"
 	"github.com/turbot/steampipe-plugin-sdk/v5/plugin"
@@ -23,8 +25,8 @@ func objectMetadataColumns() []*plugin.Column {
 		{Name: "generate_name", Type: proto.ColumnType_STRING, Transform: transform.FromField("Description.MetaObject.GenerateName"), Description: "GenerateName is an optional prefix, used by the server, to generate a unique name ONLY IF the Name field has not been provided."},
 		{Name: "resource_version", Type: proto.ColumnType_STRING, Transform: transform.FromField("Description.MetaObject.ResourceVersion"), Description: "An opaque value that represents the internal version of this object that can be used by clients to determine when objects have changed."},
 		{Name: "generation", Type: proto.ColumnType_INT, Transform: transform.FromField("Description.MetaObject.Generation"), Description: "A sequence number representing a specific generation of the desired state."},
-		{Name: "creation_timestamp", Type: proto.ColumnType_TIMESTAMP, Transform: transform.FromField("Description.MetaObject.CreationTimestamp").Transform(v1TimeToRFC3339), Description: "CreationTimestamp is a timestamp representing the server time when this object was created."},
-		{Name: "deletion_timestamp", Type: proto.ColumnType_TIMESTAMP, Transform: transform.FromField("Description.MetaObject.DeletionTimestamp").Transform(v1TimeToRFC3339), Description: "DeletionTimestamp is RFC 3339 date and time at which this resource will be deleted."},
+		//{Name: "creation_timestamp", Type: proto.ColumnType_TIMESTAMP, Transform: transform.FromField("Description.MetaObject.CreationTimestamp").NullIfZero(), Description: "CreationTimestamp is a timestamp representing the server time when this object was created."},
+		//{Name: "deletion_timestamp", Type: proto.ColumnType_TIMESTAMP, Transform: transform.FromField("Description.MetaObject.DeletionTimestamp").NullIfZero(), Description: "DeletionTimestamp is RFC 3339 date and time at which this resource will be deleted."},
 		{Name: "deletion_grace_period_seconds", Type: proto.ColumnType_INT, Transform: transform.FromField("Description.MetaObject.DeletionGracePeriodSeconds"), Description: "Number of seconds allowed for this object to gracefully terminate before it will be removed from the system.  Only set when deletionTimestamp is also set."},
 		{Name: "labels", Type: proto.ColumnType_JSON, Transform: transform.FromField("Description.MetaObject.Labels"), Description: "Map of string keys and values that can be used to organize and categorize (scope and select) objects. May match selectors of replication controllers and services."},
 		{Name: "annotations", Type: proto.ColumnType_JSON, Transform: transform.FromField("Description.MetaObject.Annotations"), Description: "Annotations is an unstructured key value map stored with a resource that may be set by external tools to store and retrieve arbitrary metadata."},

discovery/provider/model_helpers.go

@@ -18,19 +18,15 @@ type Time struct {
 	time.Time
 }
 
-func ConvertTime(timestamp metav1.Time) Time {
-	return Time{
-		timestamp.Time,
-	}
+func ConvertTime(timestamp metav1.Time) time.Time {
+	return timestamp.Time
 }
 
-func ConvertTimePtr(timestamp *metav1.Time) *Time {
+func ConvertTimePtr(timestamp *metav1.Time) *time.Time {
 	if timestamp == nil {
 		return nil
 	}
-	return &Time{
-		timestamp.Time,
-	}
+	return &timestamp.Time
 }
 
 type FieldsV1 struct {
@@ -79,7 +75,7 @@ type ManagedFieldsEntry struct {
 	Manager     string
 	Operation   ManagedFieldsOperationType
 	APIVersion  string
-	Time        *Time
+	Time        *time.Time
 	FieldsType  string
 	FieldsV1    *FieldsV1
 	Subresource string
@@ -121,8 +117,8 @@ type ObjectMeta struct {
 	UID                        types.UID
 	ResourceVersion            string
 	Generation                 int64
-	CreationTimestamp          Time
-	DeletionTimestamp          *Time
+	CreationTimestamp          time.Time
+	DeletionTimestamp          *time.Time
 	DeletionGracePeriodSeconds *int64
 	Labels                     map[string]string
 	Annotations                map[string]string