openHAB app icon is clipped when used in watch face complication

[curlyel]

Describe the bug
Well, not really a bug more a cosmetic issue...

When using openHAB-complication on the watch face to gain quicker access to the openHAB sitemap, the used icon seems to be slightly to high/wide resulting in a clipped icon presented.

Additionally, the used icon appears a bit too heavy in my opinion due to the filled background of the selected icon.

To Reproduce
Steps to reproduce the behavior:

1. select "openHAB" in watch face complication selection

Expected behavior
If the icon needs to be scaled to fit into the available space, scale it down to avoid the clipping.
When doing so, mind even changing the icon used for the watch face complication less heavier, probably take this one:

This seems to be intended for dark backgrounds.
This might work even for lighter watch faces.

Screenshots

App (please complete the following information):

• Testflight Version 3.1.41(98)

Smartphone (please complete the following information):

• Device: Watch Ultra 3

openHAB (please complete the following information):

• Version 4.3.5

[timbms]

@DigiH could you please have a look into this issue?

[DigiH]

I don't see this having anything to do with the app icon per se, as complications require their own icon sets for the different complication styles.

The current complication code references the image OHTemplateIcon which is present as a monochrome white openHAB logo in PDF format

https://github.com/openhab/openhab-ios/blob/develop/openHABWatch/Extension/Assets.xcassets/OHTemplateIcon.imageset/oh_logo_template.pdf

But there still seems to be a legacy OHIcon.imageset present with an Icon.png. It could be this icon or possibly as a last resort app icon fallback for complication use.

https://github.com/openhab/openhab-ios/tree/develop/openHABWatch/Extension/Assets.xcassets/OHIcon.imageset

What really should be used for a proper complications implementation are the Complication.complicationset entries

https://github.com/openhab/openhab-ios/tree/develop/openHABWatch/Extension/Assets.xcassets/Complication.complicationset

which are also nicely visible as image wells in Xcode - currently all of them unpopulated.

As a side note - I find using the actual app name "OPENHAB" for the graphicCorner and graphicBezel complications very odd, as it is also totally against the UI Guidelines, as this area should only be used to display changing informative details, but not a static app name.

https://github.com/openhab/openhab-ios/blob/develop/openHABWatch/Extension/ComplicationController.swift#L94C9-L98C156

So to sum things up: Apple Watch complications, even if they are currently only for opening the app, need some proper love and attention, with Complication.complicationset with non-background images being the key for current watchOS versions, and possibly still the OHTemplateIcon for older watchOS versions.

[curlyel]

as this area should only be used to display changing informative details, but not a static app name

You mean, that instead of an static icon, the complication should be some visualization of a specific openHAB item state, like the battery gauges in top left/top right complication or the rain forecast at bottom of above screenshot.

As this would be really nice to present some useful item state here, this implies the need for a definition somewhere, which item should be considered for it and which style of presentation should be used (gauge, value+UoM, icon for ON/OFF or OPEN/CLOSED or LOCKED/UNLOCKED, whatever).

Probably (preferably?) such definition can go into the watch sitemap itself as a specific extension for the watch face complication. Maybe this can be achieved by an item setting at the top level (the sitemap-line) this way:

sitemap watch **item=HousePresenceState** label="House state" {
    Frame {
      Text item=....

Depending on the item type, a suitable presentation style could choosen programatically
If none item parameter is set in the sitemap watch ... line, fallback to the app icon for the complication remains the last resort option.

Don't get me wrong, an "un-clipped" lightweight app icon for the complication is fine for me what this issue is about.
Having a useful state revealed via the openHAB watch face complication would just be the next cherry on top ;-)

[DigiH]

You mean, that instead of an static icon, the complication should be some visualization of a specific openHAB item state, like the battery gauges in top left/top right complication or the rain forecast at bottom of above screenshot.

Not quite ;) not instead of the icon, but the two complication types I mentioned have the icon and some other graphics or text underneath/above - with the current static app name text being out of place.

And I agree, in the future ideally this could be used to display some textual item state or graphic information, as well as instead of the icon in other single resource complications.

[curlyel]

Ahhh... I see. I've re-read your former post and with your screenshot it is much clearer now. Thanks for the clarification.

And I agree, in the future ideally this could be used to display some textual item state or graphic information, as well as instead of the icon in other single resource complications.

👍

[DigiH]

@timbms Any hint on how to get the openHAB complication working in the simulators?

I wanted to have a look at this, but cannot seem to get the openHAB section showing up in any Complications selection listing in the Watch app.

He asks - just when I figured it out :) all fine.

[timbms]

Just was about to tell you: Long press the Home Screen on simulator, just as you do on real watch

Am very curious about your progress. Instead of openHAB we could maybe write the name of the active Home.

[DigiH]

I had to find out to run openHABWatchSwift (Complication) on the combined iOS and watchOS simulators ;) working great now.

I'm currently only looking at fixing the clipped icon issue, and at the same time wondering of the dark mode logo would not be a better fit for the complications - it is more in line with the HI guidelines and also better on the OLED without a glaring white background.

What do you say?

That way to logo also stands out more in tinted modes

[timbms]

Looks great

[DigiH]

@timbms I've been playing around a bit more with this today and am wondering. Should I still implement this with the currently implemented but deprecated ComplicationController, or should we wait a bit until the other widget related PRs are implemented to port the complications to WidgetKit and SwiftUI as well?

[timbms]

Ideally I would love to jump ahead. #1028 could be a starting point

[DigiH]

Currently like this with WidgetKit/SwiftUI https://github.com/DigiH/openhab-ios/tree/complications