Notifications are consumed by app even if processing error occurs

[TAKeanice]

Problem statement

With the current TestFlight beta 3.1.24, even if the processing of an action from a notification fails, the notification is gone afterwards.

Reproducing:

1. Create any notification with an action that has an invalid definition and send it to the iOS device from OpenHAB.
   Alternatively you can create a notification with a valid action definition that requires network access and make sure there is no network connection when executing it.

2. Long-press the notification to open the available actions

3. Tap one of the actions to execute it

4. There will be an error message and the notification vanishes

Expected behavior:

The notification is not removed so the user can retry executing the notification action.

[digitaldan]

Is this something we can actually fix? I was under the impression that once you interact with a notification, IOS removes it. Maybe there's a flag or something we can set to try and persist it...... or i guess we could store the notification meta data , and if we have a failure, push the notification again locally from the app?

[TAKeanice]

The app is responsible to manage the "lifetime" of notifications. We do that in AppDelegate#application:didReceiveRemoteNotification by calling UNUserNotificationCenter.current().removeDeliveredNotifications for example.

[digitaldan]

gotcha, i don't remember doing that, agreed it would be nice to not clear if not successful , it might also be useful to not clear on any action click ...... i find that a bit annoying as i may want to click the other action or click it multiple times. So maybe we only clear when you actually click on the notification to open the app.