Skip to content

Commit f01cfc5

Browse files
authored
Merge pull request #1271 from davidharrishmc/dev
Fix regression with functional coverage split into multiple files.
2 parents 0f3b086 + fe43159 commit f01cfc5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ SIM = ${WALLY}/sim
88

99
.PHONY: all riscof testfloat combined_IF_vectors zsbl benchmarks coremark embench coverage cvw-arch-verif clean
1010

11-
all: riscof testfloat combined_IF_vectors zsbl coverage cvw-arch-verif # benchmarks
11+
all: riscof testfloat combined_IF_vectors zsbl coverage # cvw-arch-verif benchmarks
1212

1313
# riscof builds the riscv-arch-test and wally-riscv-arch-test suites
1414
riscof:

bin/regression-wally

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@ def addTestsByDir(testDir, config, sim, coverStr, configs, lockstepMode=0, breke
318318
sim_logdir = f"{regressionDir}/{sim}/logs/"
319319
cmdPrefix = f"wsim --sim {sim} {coverStr} {'--lockstep' if lockstepMode else ''} {config}"
320320
# fcov/ccov only runs on WALLY-COV-ALL.elf files; other lockstep runs on all files
321-
fileEnd = "ALL.elf" if "cvw-arch-verif/tests" in testDir and "priv" not in testDir and (coverStr == "--fcov" or coverStr == "--ccov") else ".elf"
321+
fileStart = "WALLY-COV-ALL" if "cvw-arch-verif/tests" in testDir and "priv" not in testDir and (coverStr == "--fcov" or coverStr == "--ccov") else ""
322+
fileEnd = ".elf"
322323
if lockstepMode or coverStr == "--fcov":
323324
gs = "Mismatches : 0"
324325
elif brekerMode:
@@ -327,7 +328,7 @@ def addTestsByDir(testDir, config, sim, coverStr, configs, lockstepMode=0, breke
327328
gs = "Single Elf file tests are not signatured verified."
328329
for dirpath, _, filenames in os.walk(os.path.abspath(testDir)):
329330
for file in filenames:
330-
if file.endswith(fileEnd):
331+
if file.endswith(fileEnd) and file.startswith(fileStart):
331332
fullfile = os.path.join(dirpath, file)
332333
fields = fullfile.rsplit('/', 3)
333334
if fields[2] == "ref":

0 commit comments

Comments
 (0)