-
Notifications
You must be signed in to change notification settings - Fork 837
Tokens rotation with additional headers - helper functions #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Tokens rotation with additional headers - helper functions #854
Conversation
…ders in case of tokens rotation
|
Hi @wojteklembryk, thanks for the PR! Would you be able to provide us with some info about your use case for such helper functions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed very good addition, sometimes we need to pass headers in token requests. @mdmathias could you please merge into master?
|
@ywsang A use case here is Kinde uses a header value in the request to determine which SDK is making the request. |
I can say that DPoP implementation is one such case. |
|
Hi everyone, @ywsang, there are several use cases that require passing additional headers during token rotation, such as:
Overall, this PR does not introduce any new functionality; it simply exposes the changes introduced in #770 by @mdmathias. Thanks for your suport and great work 👍 |
|
I'd like to bring back the discussion about this topic. It's a simple PR but crucial to some cases. We've been using a fork based on this branch for a long time now and it would be nice to have it merged so we can go back to using the main branch. |
Set of helpers to perform action with fresh tokens and additional headers in case of tokens rotation