Skip to content

Commit b9e5c32

Browse files
fix(ios): fix missing operationID parameter in iOS getLoginUserID (#85)
1 parent f7552ac commit b9e5c32

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

android/src/main/java/com/openimsdkrn/OpenImSdkRnModule.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1114,12 +1114,14 @@ public void logs(ReadableMap options, String operationID, Promise promise) {
11141114
}
11151115

11161116
/**
1117+
* WARN: This method is useless and will be removed in the future.
1118+
*
11171119
* This method should be an async method with Promise parameter, otherwise it is incompatible with React Native 0.80+ versions.
11181120
* Details: https://github.com/openimsdk/open-im-sdk-reactnative/issues/72
11191121
* Note: React Native 0.82+ dropped support for the old architecture.
11201122
*/
11211123
@ReactMethod
1122-
public void getSdkVersion(Promise promise) {
1124+
public void getSdkVersion(String operationID, Promise promise) {
11231125
promise.resolve(Open_im_sdk.getSdkVersion());
11241126
}
11251127

ios/OpenImSdkRn.m

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ - (NSArray *)parseJsonStr2Array:(NSString *)jsonStr {
201201
resolver(@(status));
202202
}
203203

204-
RCT_EXPORT_METHOD(getLoginUserID:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
204+
RCT_EXPORT_METHOD(getLoginUserID:(NSString *)operationID resolver:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
205205
NSString* uid = Open_im_sdkGetLoginUserID();
206206
resolver(uid);
207207
}
@@ -1246,7 +1246,8 @@ - (NSArray *)parseJsonStr2Array:(NSString *)jsonStr {
12461246
Open_im_sdkLogs(proxy, operationID, [[options valueForKey:@"logLevel"] longValue],[options valueForKey:@"file"],[[options valueForKey:@"line"] longValue],[options valueForKey:@"msgs"],[options valueForKey:@"err"],[keyAndValue json]);
12471247
}
12481248

1249-
RCT_EXPORT_METHOD(getSdkVersion:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
1249+
// WARN: This method is useless and will be removed in the future.
1250+
RCT_EXPORT_METHOD(getSdkVersion:(NSString *)operationID resolver:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
12501251
NSString *version = Open_im_sdkGetSdkVersion();
12511252
resolver(version);
12521253
}

0 commit comments

Comments
 (0)