support key_dimensions (#38)

Signed-off-by: Jared Tan <[email protected]>

Author: JaredTan95

connector/slowsqlconnector/config.go

@@ -33,6 +33,9 @@ type Config struct {
 	// The dimensions will be fetched from the span's attributes. Examples of some conventionally used attributes:
 	// https://github.com/open-telemetry/opentelemetry-collector/blob/main/model/semconv/opentelemetry.go.
 	Dimensions []Dimension `mapstructure:"dimensions"`
+
+	// KeyDimensions defines the list of additional dimensions to build key.
+	KeyDimensions []Dimension `mapstructure:"key_dimensions"`
 	// Exemplars defines the configuration for exemplars.
 	Exemplars Exemplars `mapstructure:"exemplars"`
 }
@@ -45,6 +48,11 @@ func (c Config) Validate() error {
 	if err != nil {
 		return err
 	}
+
+	err = validateDimensions(c.KeyDimensions)
+	if err != nil {
+		return err
+	}
 	return nil
 }
 

connector/slowsqlconnector/connector_logs.go

@@ -5,6 +5,8 @@ package slowsqlconnector // import "github.com/open-telemetry/opentelemetry-coll
 
 import (
 	"context"
+	"encoding/base64"
+	"strings"
 	"time"
 
 	"go.opentelemetry.io/collector/component"
@@ -22,7 +24,8 @@ type logsConnector struct {
 	config Config
 
 	// Additional dimensions to add to logs.
-	dimensions []dimension
+	dimensions    []dimension
+	keyDimensions []dimension
 
 	logsConsumer consumer.Logs
 	component.StartFunc
@@ -35,9 +38,10 @@ func newLogsConnector(logger *zap.Logger, config component.Config) *logsConnecto
 	cfg := config.(*Config)
 
 	return &logsConnector{
-		logger:     logger,
-		config:     *cfg,
-		dimensions: newDimensions(cfg.Dimensions),
+		logger:        logger,
+		config:        *cfg,
+		dimensions:    newDimensions(cfg.Dimensions),
+		keyDimensions: newDimensions(cfg.KeyDimensions),
 	}
 }
 
@@ -131,6 +135,15 @@ func (c *logsConnector) attrToLogRecord(sl plog.ScopeLogs, serviceName string, s
 		}
 	}
 
+	var keys []string
+	encode := base64.StdEncoding
+	for _, kd := range c.keyDimensions {
+		if v, ok := getDimensionValue(kd, spanAttrs, resourceAttrs); ok {
+			keys = append(keys, encode.EncodeToString([]byte(v.Str())))
+		}
+	}
+	logRecord.Attributes().PutStr("slow_sql_agg_key", strings.Join(keys, "@"))
+
 	return logRecord
 }
 

connector/slowsqlconnector/testdata/config.yaml

@@ -12,3 +12,12 @@ slowsql/full:
   dimensions:
     - name: k8s.uuid
     - name: k8s.namespace.name
+
+  key_dimensions:
+    - name: k8s.uuid
+    - name: k8s.namespace.name
+    - name: server.address
+    - name: db.connection_string # rollback to get value for server.address
+    - name: db.system
+    - name: service.name
+    - name: db.statement