Skip to content

Commit ac00cd2

Browse files
Satyen SubramaniamPaul Hohensee
authored andcommitted
8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer
Backport-of: 1131bb77ec94dd131a10df4ba0f3fab32c65c0f2
1 parent 9ef3fb4 commit ac00cd2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,6 @@ void G1BarrierSetAssembler::g1_write_barrier_post(MacroAssembler* masm,
265265
Register thread,
266266
Register tmp,
267267
Register tmp2) {
268-
// Generated code assumes that buffer index is pointer sized.
269-
STATIC_ASSERT(in_bytes(SATBMarkQueue::byte_width_of_index()) == sizeof(intptr_t));
270268
#ifdef _LP64
271269
assert(thread == r15_thread, "must be");
272270
#endif // _LP64
@@ -317,6 +315,9 @@ void G1BarrierSetAssembler::g1_write_barrier_post(MacroAssembler* masm,
317315

318316
__ movb(Address(card_addr, 0), (int)G1CardTable::dirty_card_val());
319317

318+
// The code below assumes that buffer index is pointer sized.
319+
STATIC_ASSERT(in_bytes(G1DirtyCardQueue::byte_width_of_index()) == sizeof(intptr_t));
320+
320321
__ movptr(tmp2, queue_index);
321322
__ testptr(tmp2, tmp2);
322323
__ jcc(Assembler::zero, runtime);

0 commit comments

Comments
 (0)