Skip to content

Commit 5cce770

Browse files
committed
8302226: failure_handler native.core should wait for coredump to finish
Backport-of: 6120319afdba98b5ff547b870a0260479e8b683c
1 parent 4070736 commit 5cce770

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

test/failure_handler/src/share/conf/linux.properties

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,11 @@ native.stack.args.delimiter=\0
5454
native.stack.params.repeat=6
5555

5656
# has to be the last command
57-
native.core.app=kill
58-
native.core.args=-ABRT %p
57+
native.core.app=bash
58+
# The below trick was found on https://stackoverflow.com/a/41613532
59+
native.core.args=-c\0kill -ABRT %p && tail --pid=%p -f /dev/null
60+
native.core.args.delimiter=\0
61+
native.core.timeout=600000
5962

6063
cores=native.gdb
6164
native.gdb.app=gdb

test/failure_handler/src/share/conf/mac.properties

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,11 @@ native.stack.params.repeat=6
6262
native.stack.args=-c\0DevToolsSecurity --status | grep -q enabled && lldb -o 'attach %p' -o 'thread backtrace all' -o 'detach' -o 'quit'
6363

6464
# has to be the last command
65-
native.core.app=kill
66-
native.core.args=-ABRT %p
65+
native.core.app=bash
66+
# The below trick was found on https://stackoverflow.com/a/41613532
67+
native.core.args=-c\0kill -ABRT %p && lsof -p %p +r 1 &>/dev/null
68+
native.core.delimiter=\0
69+
native.core.timeout=600000
6770

6871
cores=native.lldb
6972
native.lldb.app=lldb

0 commit comments

Comments
 (0)