Skip to content

Commit 605f8dd

Browse files
zifeihanRealFYang
authored andcommitted
8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
Backport-of: a4ca626
1 parent 2273ff9 commit 605f8dd

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/hotspot/cpu/riscv/templateTable_riscv.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ void TemplateTable::patch_bytecode(Bytecodes::Code bc, Register bc_reg,
179179
__ la(temp_reg, Address(temp_reg, in_bytes(ResolvedFieldEntry::put_code_offset())));
180180
}
181181
// Load-acquire the bytecode to match store-release in ResolvedFieldEntry::fill_in()
182-
__ membar(MacroAssembler::AnyAny);
183182
__ lbu(temp_reg, Address(temp_reg, 0));
184183
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
185184
__ mv(bc_reg, bc);
@@ -321,7 +320,6 @@ void TemplateTable::ldc(LdcType type) {
321320
// get type
322321
__ addi(x13, x11, tags_offset);
323322
__ add(x13, x10, x13);
324-
__ membar(MacroAssembler::AnyAny);
325323
__ lbu(x13, Address(x13, 0));
326324
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
327325

@@ -2190,7 +2188,6 @@ void TemplateTable::resolve_cache_and_index_for_method(int byte_no,
21902188
break;
21912189
}
21922190
// Load-acquire the bytecode to match store-release in InterpreterRuntime
2193-
__ membar(MacroAssembler::AnyAny);
21942191
__ lbu(temp, Address(temp, 0));
21952192
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
21962193

@@ -2242,7 +2239,6 @@ void TemplateTable::resolve_cache_and_index_for_field(int byte_no,
22422239
__ la(temp, Address(Rcache, in_bytes(ResolvedFieldEntry::put_code_offset())));
22432240
}
22442241
// Load-acquire the bytecode to match store-release in ResolvedFieldEntry::fill_in()
2245-
__ membar(MacroAssembler::AnyAny);
22462242
__ lbu(temp, Address(temp, 0));
22472243
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
22482244
__ mv(t0, (int) code); // have we resolved this bytecode?
@@ -2404,7 +2400,6 @@ void TemplateTable::load_invokedynamic_entry(Register method) {
24042400
Label resolved;
24052401

24062402
__ load_resolved_indy_entry(cache, index);
2407-
__ membar(MacroAssembler::AnyAny);
24082403
__ ld(method, Address(cache, in_bytes(ResolvedIndyEntry::method_offset())));
24092404
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
24102405

@@ -2419,7 +2414,6 @@ void TemplateTable::load_invokedynamic_entry(Register method) {
24192414
__ call_VM(noreg, entry, method);
24202415
// Update registers with resolved info
24212416
__ load_resolved_indy_entry(cache, index);
2422-
__ membar(MacroAssembler::AnyAny);
24232417
__ ld(method, Address(cache, in_bytes(ResolvedIndyEntry::method_offset())));
24242418
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
24252419

@@ -3534,7 +3528,6 @@ void TemplateTable::_new() {
35343528
const int tags_offset = Array<u1>::base_offset_in_bytes();
35353529
__ add(t0, x10, x13);
35363530
__ la(t0, Address(t0, tags_offset));
3537-
__ membar(MacroAssembler::AnyAny);
35383531
__ lbu(t0, t0);
35393532
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
35403533
__ sub(t1, t0, (u1)JVM_CONSTANT_Class);
@@ -3653,7 +3646,6 @@ void TemplateTable::checkcast() {
36533646
// See if bytecode has already been quicked
36543647
__ add(t0, x13, Array<u1>::base_offset_in_bytes());
36553648
__ add(x11, t0, x9);
3656-
__ membar(MacroAssembler::AnyAny);
36573649
__ lbu(x11, x11);
36583650
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
36593651
__ sub(t0, x11, (u1)JVM_CONSTANT_Class);
@@ -3709,7 +3701,6 @@ void TemplateTable::instanceof() {
37093701
// See if bytecode has already been quicked
37103702
__ add(t0, x13, Array<u1>::base_offset_in_bytes());
37113703
__ add(x11, t0, x9);
3712-
__ membar(MacroAssembler::AnyAny);
37133704
__ lbu(x11, x11);
37143705
__ membar(MacroAssembler::LoadLoad | MacroAssembler::LoadStore);
37153706
__ sub(t0, x11, (u1)JVM_CONSTANT_Class);

0 commit comments

Comments
 (0)