8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method

Andrei Pangin · shipilev · commit 7e1ea5159118 · 2024-10-29T15:43:49.000Z
Reviewed-by: stuefe, shade
diff --git a/hotspot/src/share/vm/prims/forte.cpp b/hotspot/src/share/vm/prims/forte.cpp
@@ -553,7 +553,8 @@ void AsyncGetCallTrace(ASGCT_CallTrace *trace, jint depth, void* ucontext) {
     return;
   }
 
-  // !important! make sure all to call thread->set_in_asgct(false) before every return
+  // !important! make sure all to call thread->set_in_asgct(saved_in_asgct) before every return
+  bool saved_in_asgct = thread->in_asgct();
   thread->set_in_asgct(true);
 
   switch (thread->thread_state()) {
@@ -613,7 +614,7 @@ void AsyncGetCallTrace(ASGCT_CallTrace *trace, jint depth, void* ucontext) {
     trace->num_frames = ticks_unknown_state; // -7
     break;
   }
-  thread->set_in_asgct(false);
+  thread->set_in_asgct(saved_in_asgct);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -553,7 +553,8 @@ void AsyncGetCallTrace(ASGCT_CallTrace trace, jint depth, void ucontext) {`
`553`	`553`	`return;`
`554`	`554`	`}`
`555`	`555`
`556`		`- // !important! make sure all to call thread->set_in_asgct(false) before every return`
	`556`	`+ // !important! make sure all to call thread->set_in_asgct(saved_in_asgct) before every return`
	`557`	`+ bool saved_in_asgct = thread->in_asgct();`
`557`	`558`	`thread->set_in_asgct(true);`
`558`	`559`
`559`	`560`	`switch (thread->thread_state()) {`
`@@ -613,7 +614,7 @@ void AsyncGetCallTrace(ASGCT_CallTrace trace, jint depth, void ucontext) {`
`613`	`614`	`trace->num_frames = ticks_unknown_state; // -7`
`614`	`615`	`break;`
`615`	`616`	`}`
`616`		`- thread->set_in_asgct(false);`
	`617`	`+ thread->set_in_asgct(saved_in_asgct);`
`617`	`618`	`}`
`618`	`619`
`619`	`620`