Skip to content

8364806: Test sun/security/krb5/config/IncludeRandom.java times out on Windows #26720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8364806: Test sun/security/krb5/config/IncludeRandom.java times out on Windows #26720

wants to merge 1 commit into from
+1 −1

Conversation

smemery
Copy link
Contributor

@smemery smemery commented Aug 11, 2025 •
edited by openjdk bot
Loading

Here's a draft PR for the time out bug on Windows. I haven't verified the fix, but will test late this week.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364806: Test sun/security/krb5/config/IncludeRandom.java times out on Windows (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26720/head:pull/26720
$ git checkout pull/26720

Update a local copy of the PR:
$ git checkout pull/26720
$ git pull https://git.openjdk.org/jdk.git pull/26720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26720

View PR using the GUI difftool:
$ git pr show -t 26720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26720.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

👋 Welcome back smemery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025 •
edited
Loading

@smemery This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364806: Test sun/security/krb5/config/IncludeRandom.java times out on Windows

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@smemery The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@MBaesken
Copy link
Member

Will test this in our CI .

@smemery
Copy link
Contributor Author

smemery commented Aug 11, 2025

Will test this in our CI .

Thank you @MBaesken!

@smemery
Copy link
Contributor Author

smemery commented Aug 17, 2025

Thank you for your approval and verifying the code change in your CI.

@smemery smemery marked this pull request as ready for review August 17, 2025 21:02
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2025

Webrevs

@wangweij
Copy link
Contributor

@smemery Please add a noreg-self label to the JBS issue.

@smemery
Copy link
Contributor Author

smemery commented Aug 17, 2025

@wangweij, thank you for catching this. Done!

@smemery
Copy link
Contributor Author

smemery commented Aug 18, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

@smemery
Your change (at version 29f2aec) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 18, 2025

Going to push as commit e04a310.
Since your change was applied there have been 94 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2025
@openjdk openjdk bot closed this Aug 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

@wangweij @smemery Pushed as commit e04a310.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MBaesken MBaesken MBaesken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
integrated Pull request has been integrated security [email protected]
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smemery @MBaesken @wangweij