8370910: Cleanup terminology of UUID vs Global Identifiers in UUID #28435
Conversation
|
👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into |
|
@kieran-farrell This change is no longer ready for integration - check the PR body for details. |
|
@kieran-farrell The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Looks straight-forward. |
|
PR description edited to include correct Bug ID |
| @@ -35,7 +35,7 @@ | |||
| * A class that represents an immutable universally unique identifier (UUID). | |||
There was a problem hiding this comment.
Maybe change this to "Universally Unique IDentifier (UUID)" too.
| * A UUID represents a 128-bit value. | ||
| * | ||
| * <p> There exist different variants of these global identifiers. The methods | ||
| * <p> There exist different variants of these UUIDs. The methods |
There was a problem hiding this comment.
What would you think about replacing this paragraph with this:
"This class is primarily designed for manipulating Leach-Salz variant UUIDs, but it also supports the creation of UUIDs of other variants."
4 participants
Replacing 'global identifier' with 'UUID' for consistancy in the spec as suggested during the review of JDK-8334015.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28435/head:pull/28435$ git checkout pull/28435Update a local copy of the PR:
$ git checkout pull/28435$ git pull https://git.openjdk.org/jdk.git pull/28435/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28435View PR using the GUI difftool:
$ git pr show -t 28435Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28435.diff
Using Webrev
Link to Webrev Comment