Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 21, 2025

Please review this change to FreeListAllocator to use Atomic rather than
directly applying AtomicAccess to volatile members.

Testing: mach5 tier1-5


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372240: Convert FreeListAllocator to use Atomic<T> (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28447/head:pull/28447
$ git checkout pull/28447

Update a local copy of the PR:
$ git checkout pull/28447
$ git pull https://git.openjdk.org/jdk.git pull/28447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28447

View PR using the GUI difftool:
$ git pr show -t 28447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28447.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372240: Convert FreeListAllocator to use Atomic<T>

Reviewed-by: tschatzl, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 88ec4e6: 8372154: AArch64: Match rule failure with some CompareAndSwap operand shapes
  • eeb7c3f: 8371895: Lower GCTimeLimit in TestUseGCOverheadLimit.java
  • 5922c3c: 8371990: Remove two second delayed OOME after GC shutdown

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

@tschatzl
Copy link
Contributor

/touch

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@tschatzl The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants