Skip to content

8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization" #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization" #3071

wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Aug 18, 2025 •
edited by openjdk bot
Loading

Mostly clean backport of JDK-8357105. Backport is not clean because JDK11 C++ uses NULL instead of nulllptr.

Tested on Linux with:

tier1 tests:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier1                     1497  1497     0     0   
   jtreg:test/jdk:tier1                               1899  1899     0     0   
   jtreg:test/langtools:tier1                         3941  3941     0     0   
   jtreg:test/nashorn:tier1                              0     0     0     0   
   jtreg:test/jaxp:tier1                                 0     0     0     0   
==============================
TEST SUCCESS

The test itself

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg/compiler/stringopts/TestStackedConcatsAppendUncommonTrap.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

and gtests

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   gtest:all/server                                    504   504     0     0   
==============================
TEST SUCCESS

Reproducing this on 11 requires the additional flags -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure . I'm wondering if we want to add these additional flags to the new test too for 11...

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357105 needs maintainer approval

Issue

  • JDK-8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization" (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3071/head:pull/3071
$ git checkout pull/3071

Update a local copy of the PR:
$ git checkout pull/3071
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3071

View PR using the GUI difftool:
$ git pr show -t 3071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3071.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2025

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport de454c7faa2a2369d316bbea4407aab4e179c660 8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization" Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 18, 2025
@openjdk
Copy link

openjdk bot commented Aug 18, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2025

Webrevs

@vieiro vieiro marked this pull request as draft August 19, 2025 10:17
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 19, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Aug 21, 2025

Also ran tier2 tests (rhel8/x86_64), that return the same results than when ran in master.

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier2                      329   329     0     0   
>> jtreg:test/jdk:tier2                               3514  3510     4     0 <<
   jtreg:test/langtools:tier2                           11    11     0     0   
   jtreg:test/nashorn:tier2                             36    36     0     0   
   jtreg:test/jaxp:tier2                               445   445     0     0   
==============================
TEST FAILURE

Failures are unrelated, one of them requires approval of the JDK-8365811 backport.

@vieiro vieiro marked this pull request as ready for review August 21, 2025 13:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Aug 21, 2025

/approval request Please consider approving this CPU25_07-critical-approved backport for 11. Clean. Medium risk as it changes C2 (probably medium-high for JDK11?), but we should have enough time to test it before 25/10. tier1, tier2 and gtests passed on Linux/x86_64.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@vieiro
8357105: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 21, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@vieiro
Copy link
Contributor Author

vieiro commented Sep 19, 2025

This is jdk11u-defer-next, so let's wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vieiro