You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #3088 as a prerequisite.
Progress
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/3088 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: bundles-macos-x64
Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md
@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:
git checkout 8263622-8347377
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push
backportPort of a pull request already in a different code baserfrPull request is ready for review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjdk
bot
changed the title
ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #3088 as a prerequisite.
Progress
Warning
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3089/head:pull/3089$ git checkout pull/3089Update a local copy of the PR:
$ git checkout pull/3089$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3089/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3089View PR using the GUI difftool:
$ git pr show -t 3089Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3089.diff
Using Webrev
Link to Webrev Comment