-
Notifications
You must be signed in to change notification settings - Fork 253
8305186: Reference.waitForReferenceProcessing should be more accessible to tests #3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
I have verified this clean backport PR locally with test test/jdk/java/lang/ref/FinalizerHistogramTest.java which use the newly added function. |
Webrevs
|
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Hi all,
This pull request contains a backport of commit d8f012ea from the openjdk/jdk repository.
The commit being backported was authored by Brent Christian on 25 Apr 2025 and was reviewed by Kim Barrett.
The github shows it's not cleanly backport, seems that this file has different context. I compare the patch file from main-line repo and jdk11u-dev repo, the change lines are all the same.
I have verified this clean backport PR locally with test test/jdk/java/lang/ref/FinalizerHistogramTest.java after apply the patch JDK-8298783 which use the newly added function.
Thanks!
Progress
Integration blocker
8305186. Please make sure it exists and is accessible.Issue
8305186.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3105/head:pull/3105$ git checkout pull/3105Update a local copy of the PR:
$ git checkout pull/3105$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3105/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3105View PR using the GUI difftool:
$ git pr show -t 3105Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3105.diff
Using Webrev
Link to Webrev Comment