8361117: SIGSEGV in LShiftLNode::Ideal due to unexpected dead node #4204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with |
openjdk
bot
added
backport
Contributor
Author
|
@rwestrel: Do you want to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new fix for JDK-8361117 for OpenJDK. I can't see the corresponding fix because it's not public.
This fix is taken from openjdk/jdk@05a0a71.
The problem is described in https://github.com/openjdk/jdk/blob/674cc3eeca77f1f2a6d937b1df5c5cd8a13c2d31/test/hotspot/jtreg/compiler/arraycopy/TestACSameSrcDst.java#L87 but that regression test didn't reproduce the issue in jdk17u.
I've taken the reproducer from the issue and put it into a new regression test. The VM crashes without the fix and the test passes with the fix.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4204/head:pull/4204$ git checkout pull/4204Update a local copy of the PR:
$ git checkout pull/4204$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4204/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4204View PR using the GUI difftool:
$ git pr show -t 4204Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4204.diff
Using Webrev
Link to Webrev Comment