Skip to content

8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GoeLin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS #2565

GoeLin wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 23, 2026 •
edited by openjdk bot
Loading

This fixes an issue spotted by Mikael Sterner, thanks!!

Unfortunately the bug "8355884: [macos] java/awt/Frame/I18NTitle.java fails on MacOS" is closed.

Addon: I opened https://bugs.openjdk.org/browse/JDK-8376251 for this.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8376251 needs maintainer approval

Integration blocker

 ⚠️ Issue of type Backport is not allowed for integrations

Issue

  • JDK-8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS (Backport - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2565/head:pull/2565
$ git checkout pull/2565

Update a local copy of the PR:
$ git checkout pull/2565
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2565

View PR using the GUI difftool:
$ git pr show -t 2565

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2565.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 does not exist in project JDK.

@GoeLin GoeLin changed the title backport 8355884 backport 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 from commit 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 does not exist in project JDK.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 23, 2026

@GoeLin For those cases we should be using Backport JDK-8355884 in the PR title so it's recognized as a backport with an unknown sha. Could you try that please?

jerboaa
jerboaa approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean from openjdk/jdk25u-dev@52e1e73

@jerboaa jerboaa mentioned this pull request Jan 23, 2026
Open
1 task
@jerboaa
Copy link
Contributor

jerboaa commented Jan 23, 2026

Asked here if it's meant to be private: https://mail.openjdk.org/pipermail/jdk-dev/2026-January/010787.html

@GoeLin GoeLin changed the title backport 2eaddd5b0a18d762ced7fea845ffa1a9e675e095 backport 52e1e739afd419e8a5d153a27f5d145c498e4ebf Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @GoeLin the issue with id 8355884 from commit 52e1e739afd419e8a5d153a27f5d145c498e4ebf does not exist in project JDK.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 24, 2026 •
edited
Loading

Hmm, the sha is known, I got it wrong somehow. But fixing this did not help either...

@GoeLin GoeLin changed the title backport 52e1e739afd419e8a5d153a27f5d145c498e4ebf Backport JDK-8355884 Jan 24, 2026
@GoeLin GoeLin changed the title Backport JDK-8355884 8376251: [macos] java/awt/Frame/I18NTitle.java fails on MacOS Jan 24, 2026
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Jan 24, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jerboaa jerboaa jerboaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval Requires approval; will be removed when approval is received rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @jerboaa