Skip to content

8369947: Bytecode rewriting causes Java heap corruption on RISC-V #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8369947: Bytecode rewriting causes Java heap corruption on RISC-V #323

wants to merge 1 commit into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Oct 18, 2025 •
edited by openjdk bot
Loading

Hi all,

This pull request contains a backport of commit 46251993 from the openjdk/jdk repository.

The commit being backported was authored by Feilong Jiang on 18 Oct 2025 and was reviewed by Andrew Haley, Justin King and Fei Yang.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369947 needs maintainer approval

Issue

  • JDK-8369947: Bytecode rewriting causes Java heap corruption on RISC-V (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/323/head:pull/323
$ git checkout pull/323

Update a local copy of the PR:
$ git checkout pull/323
$ git pull https://git.openjdk.org/jdk25u.git pull/323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 323

View PR using the GUI difftool:
$ git pr show -t 323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/323.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2025

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2025 •
edited
Loading

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369947: Bytecode rewriting causes Java heap corruption on RISC-V

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 462519935827e25475f2fb35746ad81a14bc5da7 8369947: Bytecode rewriting causes Java heap corruption on RISC-V Oct 18, 2025
@openjdk
Copy link

openjdk bot commented Oct 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 18, 2025
@openjdk
Copy link

openjdk bot commented Oct 18, 2025

⚠️ @feilongjiang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2025
@feilongjiang
Copy link
Member Author

/approval request Clean backport to fix heap corruption caused by bytecode rewriting on RISC-V

@openjdk
Copy link

openjdk bot commented Oct 18, 2025

@feilongjiang
8369947: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 18, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 20, 2025
@feilongjiang
Copy link
Member Author

GHA macOS arm64 failure seems not related, as this backport only modifies riscv, going to integrate.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@feilongjiang
Your change (at version 7b118dc) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

Going to push as commit cd99e8f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2025
@openjdk openjdk bot closed this Oct 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 20, 2025
@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@RealFYang @feilongjiang Pushed as commit cd99e8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feilongjiang @RealFYang