Skip to content

Commit 04dbdd3

Browse files
turbanoffSerguei Spitsyn
authored andcommitted
8274898: Cleanup usages of StringBuffer in jdk tools modules
Reviewed-by: sspitsyn, lmesnik
1 parent 7517c85 commit 04dbdd3

File tree

3 files changed

+8
-8
lines changed
  • src
    • jdk.jartool/share/classes/sun/security/tools/jarsigner
    • jdk.jpackage/share/classes/jdk/jpackage/internal
    • jdk.jshell/share/classes/jdk/internal/jshell/tool

3 files changed

+8
-8
lines changed

src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -834,9 +834,9 @@ void verifyJar(String jarName)
834834
}
835835

836836
// Only used when -verbose provided
837-
StringBuffer sb = null;
837+
StringBuilder sb = null;
838838
if (verbose != null) {
839-
sb = new StringBuffer();
839+
sb = new StringBuilder();
840840
boolean inManifest =
841841
((man.getAttributes(name) != null) ||
842842
(man.getAttributes("./"+name) != null) ||

src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,21 @@ public void verbose(String msg) {
108108
public void verbose(List<String> strings,
109109
List<String> output, int returnCode, long pid) {
110110
if (verbose) {
111-
StringBuffer sb = new StringBuffer();
111+
StringBuilder sb = new StringBuilder();
112112
sb.append("Command [PID: ");
113113
sb.append(pid);
114114
sb.append("]:\n ");
115115

116116
for (String s : strings) {
117117
sb.append(" " + s);
118118
}
119-
verbose(new String(sb));
119+
verbose(sb.toString());
120120
if (output != null && !output.isEmpty()) {
121-
sb = new StringBuffer("Output:");
121+
sb = new StringBuilder("Output:");
122122
for (String s : output) {
123123
sb.append("\n " + s);
124124
}
125-
verbose(new String(sb));
125+
verbose(sb.toString());
126126
}
127127
verbose("Returned: " + returnCode + "\n");
128128
}

src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Feedback.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -372,7 +372,7 @@ String format(String field, Selector selector) {
372372
return "";
373373
}
374374
Matcher m = FIELD_PATTERN.matcher(format);
375-
StringBuffer sb = new StringBuffer(format.length());
375+
StringBuilder sb = new StringBuilder(format.length());
376376
while (m.find()) {
377377
String fieldName = m.group(1);
378378
String sub = format(fieldName, selector);

0 commit comments

Comments
 (0)