Skip to content

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Nov 20, 2025

The test executes subprocess with -XX:+PrintInlineLayout and -XX:+PrintFlatArrayLayout arguments. These are diagnostic arguments, require -XX:+UnlockDiagnosticVMOptions to unlock.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8372304: [lworld] Test serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1754/head:pull/1754
$ git checkout pull/1754

Update a local copy of the PR:
$ git checkout pull/1754
$ git pull https://git.openjdk.org/valhalla.git pull/1754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1754

View PR using the GUI difftool:
$ git pr show -t 1754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1754.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2025

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@alexmenkov
Copy link
Author

/issue 8372304

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@alexmenkov This issue is referenced in the PR title - it will now be updated.

@alexmenkov
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset.

@alexmenkov
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset.

@alexmenkov
Copy link
Author

/issue JDK-8372304

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@alexmenkov This issue is referenced in the PR title - it will now be updated.

@alexmenkov
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@alexmenkov The pull request is being re-evaluated and the inactivity timeout has been reset.

@alexmenkov
Copy link
Author

/issue 8372304

@openjdk openjdk bot changed the title 8372304: serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build 8372304: Test serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@alexmenkov This issue is referenced in the PR title - it will now be updated.

@alexmenkov alexmenkov changed the title 8372304: Test serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build 8372304: [lworld] Test serviceability/jvmti/valhalla/HeapDump/HeapDump.java fails in product build Nov 21, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant