From e8105ce56cd92450107e353cc2d586f38df8829a Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 4 Sep 2024 16:31:30 -0400 Subject: [PATCH 1/4] Add rudimentary codespell config --- .codespellrc | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .codespellrc diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 00000000..6173043e --- /dev/null +++ b/.codespellrc @@ -0,0 +1,6 @@ +[codespell] +# Ref: https://github.com/codespell-project/codespell#using-a-config-file +skip = .git*,*.pdf,*.svg,vendor,*.lock,*.css,.codespellrc +check-hidden = true +ignore-regex= .*view=FitH.* +ignore-words-list = te,aas,nwo From 587006f5d909f3b55835cad26005dbbfee87a882 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 4 Sep 2024 16:32:59 -0400 Subject: [PATCH 2/4] [DATALAD RUNCMD] Interactively fix one typo === Do not change lines below === { "chain": [], "cmd": "codespell -w -i3 ./docs/editor_onboarding.md", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ --- docs/editor_onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/editor_onboarding.md b/docs/editor_onboarding.md index a9003e57..8c202837 100644 --- a/docs/editor_onboarding.md +++ b/docs/editor_onboarding.md @@ -79,7 +79,7 @@ All new editors at JOSS have an onboarding call with an Editor-in-Chief. You can **Wrapping up** - Make sure you've highlighted everything in the ['top tips'](editor_tips) section of our docs. -- Reinforce that this is a commitment, and thay regular attention to their submissions is absolutely critical (i.e., check in a couple of times per week). +- Reinforce that this is a commitment, and that regular attention to their submissions is absolutely critical (i.e., check in a couple of times per week). - Ask if they would like to move forward or would like time to consider the opportunity. - If they want to move forward, highlight they will receive a small number of invites: One to the JOSS editors GitHub team, a Slack invite, a Google Group invite, and an invite to the JOSS website to fill out their profile. - If they are joining the team, make sure they mark themselves as unavailable in the [JOSS reviewers database](https://reviewers.joss.theoj.org/) (so they don't get asked to review any longer). From 63a044ca24bf4b37917eaf8390c354db3d1494c7 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 4 Sep 2024 16:33:58 -0400 Subject: [PATCH 3/4] Skip for now superceded since present in the model --- .codespellrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.codespellrc b/.codespellrc index 6173043e..ef539e10 100644 --- a/.codespellrc +++ b/.codespellrc @@ -3,4 +3,5 @@ skip = .git*,*.pdf,*.svg,vendor,*.lock,*.css,.codespellrc check-hidden = true ignore-regex= .*view=FitH.* -ignore-words-list = te,aas,nwo +# TODO: fix "superceded" typo in the model +ignore-words-list = te,aas,nwo,superceded From 71dbeb274ce1df46efd16495634c769d54a38383 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 4 Sep 2024 16:34:01 -0400 Subject: [PATCH 4/4] [DATALAD RUNCMD] run codespell throughout fixing typos automagically === Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ --- app/javascript/custom/papers.js | 2 +- app/views/content/layout/_footer.html.erb | 2 +- lib/tasks/utils.rake | 2 +- spec/models/paper_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/javascript/custom/papers.js b/app/javascript/custom/papers.js index d7283e59..feeb0b05 100644 --- a/app/javascript/custom/papers.js +++ b/app/javascript/custom/papers.js @@ -13,7 +13,7 @@ authorCheck = function() { } }; -// Set the height of the paper container when loaded and everytime window is resized +// Set the height of the paper container when loaded and every time window is resized setPaperSize = function() { var height, paper, paper_container, width; if ($("#joss-paper").length > 0) { diff --git a/app/views/content/layout/_footer.html.erb b/app/views/content/layout/_footer.html.erb index 3b4985e1..f8b4b890 100644 --- a/app/views/content/layout/_footer.html.erb +++ b/app/views/content/layout/_footer.html.erb @@ -1,7 +1,7 @@
<%= link_to image_tag("osi.png", height: "65px"), "https://opensource.org" %> -

<%= Rails.application.settings['name'] %> is an affiliate of the Open Source Inititative.

+

<%= Rails.application.settings['name'] %> is an affiliate of the Open Source Initiative.

diff --git a/lib/tasks/utils.rake b/lib/tasks/utils.rake index 7754c10e..e0849604 100644 --- a/lib/tasks/utils.rake +++ b/lib/tasks/utils.rake @@ -283,7 +283,7 @@ namespace :utils do editor = review.editor.gsub('@', '') - # This is a pre-preview issue without an editor asssigned + # This is a pre-preview issue without an editor assigned if editor == "Pending" && review.pre_review? puts "Doing nothing for #{review.number}" else diff --git a/spec/models/paper_spec.rb b/spec/models/paper_spec.rb index cf9d9522..b4cd6f34 100644 --- a/spec/models/paper_spec.rb +++ b/spec/models/paper_spec.rb @@ -247,7 +247,7 @@ expect(paper.is_a_retraction_notice?).to be true end - it "should return false oherwise" do + it "should return false otherwise" do paper = create(:paper) expect(paper.retraction_for_id).to be_nil