Skip to content

sort import#249

Open
usernameisnull wants to merge 3 commits intoopenkruise:masterfrom
usernameisnull:master
Open

sort import#249
usernameisnull wants to merge 3 commits intoopenkruise:masterfrom
usernameisnull:master

Conversation

@usernameisnull
Copy link
Contributor

@usernameisnull usernameisnull commented Jul 1, 2025

sort import of code
I use this command below, maybe we can add this to the github action

goimports-reviser -excludes './vender/*',main.go -company-prefixes 'github.com/openkruise' -imports-order std,general,company,project ./...

We may have code import rules. Let me adapt the command to fit them.

@kruise-bot kruise-bot requested review from FillZpp and zmberg July 1, 2025 07:54
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @usernameisnull! It looks like this is your first PR to openkruise/kruise-game 🎉

@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.02%. Comparing base (1ca95a5) to head (f0a76f7).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   27.65%   28.02%   +0.36%     
==========================================
  Files          94       93       -1     
  Lines       10450    10666     +216     
==========================================
+ Hits         2890     2989      +99     
- Misses       7358     7471     +113     
- Partials      202      206       +4     
Flag Coverage Δ
unittests 28.02% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@usernameisnull usernameisnull force-pushed the master branch 3 times, most recently from 6a73a2a to dcd5270 Compare July 1, 2025 15:20
@usernameisnull
Copy link
Contributor Author

pltg @zmberg @FillZpp

@kruise-bot
Copy link

@usernameisnull: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments