Skip to content

E2E: ServiceQuality-driven scale down prioritizes WaitToBeDeleted#301

Open
sonalgaud12 wants to merge 4 commits intoopenkruise:masterfrom
sonalgaud12:WaitToBeDeleted
Open

E2E: ServiceQuality-driven scale down prioritizes WaitToBeDeleted#301
sonalgaud12 wants to merge 4 commits intoopenkruise:masterfrom
sonalgaud12:WaitToBeDeleted

Conversation

@sonalgaud12
Copy link

Addresses: #292

Adds an E2E test verifying that during scale-down, pods marked WaitToBeDeleted are deleted before active pods (opsState=None).

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.31%. Comparing base (40acb31) to head (6da7386).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   37.05%   37.31%   +0.26%     
==========================================
  Files         103      104       +1     
  Lines        9967    10046      +79     
==========================================
+ Hits         3693     3749      +56     
- Misses       5983     6002      +19     
- Partials      291      295       +4     
Flag Coverage Δ
unittests 37.31% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonalgaud12
Copy link
Author

Hey @ballista01 , Ready for review, all the test cases are passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments