test(e2e): add ServiceQuality-driven scale down prioritization test#307
test(e2e): add ServiceQuality-driven scale down prioritization test#307arnavgogia20 wants to merge 4 commits intoopenkruise:masterfrom
Conversation
Signed-off-by: arnavgogia20 <arnavgogia404@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @arnavgogia20! It looks like this is your first PR to openkruise/kruise-game 🎉 |
- Reconcile go.mod and go.sum after adding E2E test dependencies - Ensure module files are consistent via go mod tidy - No functional changes beyond conflict resolution Signed-off-by: arnavgogia20 <arnavgogia404@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 40.30% 40.30%
=======================================
Files 112 112
Lines 12499 12499
=======================================
Hits 5038 5038
Misses 7055 7055
Partials 406 406
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Increase WaitForPodRunning timeout to 3m - Use /bin/sh -c for exec commands to ensure execution - Add file existence verification step - Capture and report exec stdout/stderr on failure Signed-off-by: arnavgogia20 <arnavgogia404@gmail.com>
- Set ServiceQuality probe PeriodSeconds to 1 to speed up test execution - Add explicit assertion messages to aid debugging in CI Signed-off-by: arnavgogia20 <arnavgogia404@gmail.com>
|
Hii @furykerry @zmberg , the PR is ready with all the checks successful, please consider reviewing it, thankyouu |
Description
This PR adds an end-to-end test to validate ServiceQuality-driven scale-down behavior
for GameServerSets.
The test ensures that replicas marked with
opsState: WaitToBeDeletedare prioritizedfor deletion when scaling down, instead of following the default ordinal-based strategy.
Changes Made
RestConfigto the E2E framework to support SPDY-based exec operationsWaitForPodRunninghelper to ensure deterministic exec behaviorWaitToBeDeletedon a specific replica via execTesting
Related Issue
Fixes #292