-
Notifications
You must be signed in to change notification settings - Fork 866
Open
Description
Description
The ContainerRecreateRequest (CRR) controller currently has no unit test coverage, despite containing complex reconciliation logic with multiple timeout scenarios, state transitions, and edge cases.
Current State
pkg/controller/containerrecreaterequest/
├── crr_controller.go (333 lines - 0% test coverage)
├── crr_event_handler.go (97 lines - 0% test coverage)
└── NO TEST FILES ❌
Why This Matters
The CRR controller handles critical production scenarios:
- Timeout handling - Response timeout (1min), active deadline, TTL cleanup
- Pod lifecycle coordination - Handles pod deletion, UID mismatches during reconciliation
- Readiness gate management - Controls traffic flow during container restarts
- Finalizer cleanup - Prevents resource leaks
- Container status synchronization - Tracks restart progress
Proposed Solution
Add comprehensive unit tests covering
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels