-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
In src/util/gcp-kms-utils.ts it instantiates a new KeyManagementServiceClient each time sign or getPublicKey is called.
See:
| const kms = new KeyManagementServiceClient(); |
| const kms = new KeyManagementServiceClient(); |
The client maintains a gRPC channel, plus one in its referenced IAM client. close() should be called on the client when it's no longer needed.
The logical lifetime of the client is that of the GcpKmsSigner. I suggest changing it to instantiate the KeyManagementServiceClient, and pass that to the util methods.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels