Modify opacity after primitive was rendered

Author: gberaudo

cesium

@@ -420,18 +420,36 @@ goog.require('olcs.core.OlLayerPrimitive');
    * @api
    */
   olcs.core.updateCesiumPrimitives = function(olLayer, csPrimitives) {
-    //FIXME Make this work for all geometry types, not just points
-    var bbs = csPrimitives.context.billboards;
     var opacity = olLayer.getOpacity();
     if (!goog.isDef(opacity)) {
       opacity = 1;
     }
-    bbs.olLayerOpacity = opacity;
-    var i, bb;
-    for (i = bbs.length - 1; i >= 0; --i) {
-      bb = bbs.get(i);
-      //FIXME Use Cesium.Color.fromAlpha after the next Cesium update
-      bb.color = new Cesium.Color(1.0, 1.0, 1.0, bb.olStyleOpacity * opacity);
+    csPrimitives.olLayerOpacity = opacity;
+    var i, bb, j, prim, geoms, geom, color;
+    for (i = csPrimitives.length - 1; i >= 0; --i) {
+      prim = csPrimitives.get(i);
+      if (prim instanceof Cesium.PrimitiveCollection) {
+        olcs.core.updateCesiumPrimitives(olLayer, prim);
+      } else {
+        if (!prim.ready) continue;
+        var attrs = prim.getGeometryInstanceAttributes("id");
+        if (!attrs) continue;
+        color = attrs.color;
+        if (color) {
+          //FIXME This currently overrides style opacity with layer opacity
+          color[3] = Cesium.Color.floatToByte(opacity);
+          attrs.color = color;
+        }
+      }
+    }
+    if (csPrimitives instanceof olcs.core.OlLayerPrimitive) {
+      var bbs = csPrimitives.context.billboards;
+      bbs.olLayerOpacity = opacity;
+      for (i = bbs.length - 1; i >= 0; --i) {
+        bb = bbs.get(i);
+        //FIXME Use Cesium.Color.fromAlpha after the next Cesium update
+        bb.color = new Cesium.Color(1.0, 1.0, 1.0, bb.olStyleOpacity * opacity);
+      }
     }
   };
 
@@ -504,7 +522,8 @@ goog.require('olcs.core.OlLayerPrimitive');
         geometry: geometry,
         attributes: {
           color: Cesium.ColorGeometryInstanceAttribute.fromColor(color)
-        }
+        },
+        id: "id"
       });
     };
 
@@ -526,7 +545,7 @@ goog.require('olcs.core.OlLayerPrimitive');
     }
     var appearance = new Cesium.PerInstanceColorAppearance(options);
 
-    var instances = createInstance(geometry, color);
+    var instances = [createInstance(geometry, color)];
 
     var primitive = new Cesium.Primitive({
       // always update Cesium externs before adding a property
@@ -714,9 +733,10 @@ goog.require('olcs.core.OlLayerPrimitive');
 
     var outlinePrimitive = new Cesium.Primitive({
       // always update Cesium externs before adding a property
-      geometryInstances: new Cesium.GeometryInstance({
-        geometry: outlineGeometry
-      }),
+      geometryInstances: [new Cesium.GeometryInstance({
+        geometry: outlineGeometry,
+        id: "id"
+      })],
       appearance: appearance
     });