moved max pg conn to #229

Author: nyurik

bin/postserve

@@ -9,7 +9,6 @@ Usage:
                       [--pghost=<host>] [--pgport=<port>] [--dbname=<db>]
                       [--user=<user>] [--password=<password>]
                       [--test-geometry] [--verbose]
-                      [--max-pg-conn <count>]
   postserve --help
   postserve --version
 
@@ -25,7 +24,6 @@ Options:
   --no-feature-ids      Disable feature ID generation, e.g. from osm_id.
                         Feature IDS are automatically disabled with PostGIS before v3
   -g --test-geometry    Validate all geometries produced by ST_AsMvtGeom(), and warn.
-  -c --max-pg-conn <c>  Maximum number of PostgreSQL connections. Defaults to CPU count.
   -v --verbose          Print additional debugging information
   --help                Show this screen.
   --version             Show version.
@@ -68,7 +66,6 @@ def main(args):
         disable_feature_ids=args['--no-feature-ids'],
         test_geometry=args['--test-geometry'],
         verbose=args.get('--verbose'),
-        max_pg_connections=args.get('--max-pg-conn'),
     ).serve()
 
 

openmaptiles/postserve.py

@@ -1,5 +1,4 @@
 import logging
-import os
 from functools import partial
 from typing import Union, List, Any, Dict
 
@@ -138,7 +137,7 @@ class Postserve:
 
     def __init__(self, url, port, pghost, pgport, dbname, user, password,
                  layers, tileset_path, sql_file, key_column, disable_feature_ids,
-                 gzip, verbose, exclude_layers, test_geometry, max_pg_connections):
+                 gzip, verbose, exclude_layers, test_geometry):
         self.url = url
         self.port = port
         self.pghost = pghost
@@ -156,10 +155,6 @@ def __init__(self, url, port, pghost, pgport, dbname, user, password,
         self.test_geometry = test_geometry
         self.verbose = verbose
 
-        if max_pg_connections is None:
-            max_pg_connections = os.cpu_count() or 1
-        self.max_pg_connections = max_pg_connections
-
         self.tileset = Tileset.parse(self.tileset_path)
 
     def create_metadata(self,
@@ -259,16 +254,12 @@ def serve(self):
         access_log.setLevel(logging.INFO if self.verbose else logging.ERROR)
 
         print(f'Connecting to PostgreSQL at {self.pghost}:{self.pgport}, '
-              f'db={self.dbname}, user={self.user}, '
-              f'up to {self.max_pg_connections} simultaneous connections...')
+              f'db={self.dbname}, user={self.user}...')
         io_loop = IOLoop.current()
         self.pool = io_loop.run_sync(partial(
             create_pool,
             dsn=f"postgresql://{self.user}:{self.password}@"
-                f"{self.pghost}:{self.pgport}/{self.dbname}",
-            min_size=min(2, self.max_pg_connections),
-            max_size=self.max_pg_connections,
-        ))
+                f"{self.pghost}:{self.pgport}/{self.dbname}"))
         io_loop.run_sync(partial(self.init_connection))
 
         if self.sql_file: