Skip to content

Commit 5f3f181

Browse files
committed
Refer to submit button via auto-id
1 parent 920e9bf commit 5f3f181

File tree

4 files changed

+14
-91
lines changed

4 files changed

+14
-91
lines changed

app/templates/bulletins/fields.hbs

Lines changed: 0 additions & 75 deletions
This file was deleted.

app/templates/components/bulletin-editor.hbs

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
1-
<div class="row quick-save">
2-
<div class="col-md-12">
3-
<button type="submit"
4-
{{action (action this.attrs.onsave bulletin)}}
5-
class="btn btn-primary save-bulletin"
6-
disabled={{disableSaveButton}}
7-
data-auto-id="bulletin-submit">
8-
Save
9-
</button>
10-
</div>
11-
</div>
121
<form action="#">
2+
<div class="row quick-save">
3+
<div class="col-md-12">
4+
<button {{action (action this.attrs.onsave bulletin)}}
5+
class="btn btn-primary save-bulletin"
6+
disabled={{disableSaveButton}}
7+
data-auto-id="bulletin-submit-top">
8+
Save
9+
</button>
10+
</div>
11+
</div>
1312
<div class="row">
1413
<section class="service-information col-lg-6" data-test-id="bulletin-form">
1514
<div class="card">
@@ -91,11 +90,10 @@
9190
</div>
9291
<div class="row">
9392
<div class="col-md-12">
94-
<button type="submit"
95-
{{action (action this.attrs.onsave bulletin)}}
93+
<button {{action (action this.attrs.onsave bulletin)}}
9694
class="btn btn-primary save-bulletin"
9795
disabled={{disableSaveButton}}
98-
data-auto-id="bulletin-submit">
96+
data-auto-id="bulletin-submit-bottom">
9997
Save
10098
</button>
10199
</div>

tests/pages/edit-bulletin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default PageObject.create({
88
fillName: fillable(selector("name")),
99
fillPublishedAt: fillable(`${selector("published-at")} input`),
1010
fillServiceOrder: fillable(selector("service-order")),
11-
submit: clickable('button[type=submit]'),
11+
submit: clickable(selector("submit-top")),
1212
sermon: sermonEditor,
1313
name: PageObject.value(selector("name")),
1414
publishedAt: PageObject.value(`${selector("published-at")} input`),

tests/pages/new-bulletin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default PageObject.create({
1111
publishedAt: PageObject.value(`${selector("published-at")} input`),
1212
sermonEditor,
1313
serviceOrder: PageObject.value(selector("service-order")),
14-
submit: clickable('button[type=submit]'),
14+
submit: clickable(selector("submit-top")),
1515
visit: visitable("/:groupSlug/bulletins/new")
1616
});
1717

0 commit comments

Comments
 (0)