Add pagination specs

Author: achan

app/controllers/group/index.js

@@ -3,7 +3,9 @@ import Pagination from 'ember-cli-jsonapi-pagination/mixins/controllers/jsonapi-
 
 export default Ember.Controller.extend(Pagination, {
   totalPages: Ember.computed('size', 'number', 'model.posts.[]', function() {
-    return parseInt(getParameterByName("page[number]", this.get("posts.links.last")));
+    const pageParam =
+      getParameterByName("page[number]", this.get("posts.links.last"));
+    return parseInt(pageParam || 0);
   })
 });
 
@@ -12,8 +14,7 @@ function getParameterByName(name, url) {
   const regex = new RegExp("[?&]" + name + "(=([^&#]*)|&|#|$)");
   const results = regex.exec(url);
 
-  if (!results) return null;
-  if (!results[2]) return "";
-
-  return decodeURIComponent(results[2].replace(/\+/g, " "));
+  if (results && results[2]) {
+    return decodeURIComponent(results[2].replace(/\+/g, " "));
+  }
 }

tests/acceptance/group/index-test.js

@@ -25,7 +25,8 @@ test("handles groups that do not exist", function(assert) {
 
 test("renders appropriate group details", function(assert) {
   const group = server.create("group", { slug: "random" });
-  const posts = server.createList("post", 3, { group });
+  const posts = server.createList("post", 15, { group });
+  server.createList("post", 5, { group });
 
   page.visit({ slug: group.slug });
 
@@ -36,6 +37,7 @@ test("renders appropriate group details", function(assert) {
     assert.equal(page.bannerUrl(), `https://res.cloudinary.com/${ENV['CLOUDINARY_CLOUD_NAME']}/image/fetch/w_1920/${group.bannerUrl}`);
     assert.equal(page.profilePictureUrl(), `https://res.cloudinary.com/${ENV['CLOUDINARY_CLOUD_NAME']}/image/fetch/w_200/${group.profilePictureUrl}`);
 
+    assert.equal(page.posts().count, 15);
     posts.forEach(function(post, i) {
       assert.equal(page.posts(i).title, posts[i].title);
     });

tests/unit/controllers/group/index-test.js

@@ -4,8 +4,26 @@ moduleFor('controller:group/index', 'Unit | Controller | group/index', {
   needs: ['service:metrics', 'service:router-scroll']
 });
 
-// Replace this with your real tests.
-test('it exists', function(assert) {
-  let controller = this.subject();
-  assert.ok(controller);
+test('totalPages: Fetches the total pages from metadata', function(assert) {
+  const model = {
+    posts: {
+      links: { last: "https://mcac.church/api/v1/posts?page%5Bnumber%5D=4" }
+    }
+  };
+
+  const controller = this.subject(model);
+
+  assert.equal(controller.get("totalPages"), 4);
+});
+
+test('totalPages: Returns 0 when URL has no page number', function(assert) {
+  const model = {
+    posts: {
+      links: { last: "https://mcac.church/api/v1/posts" }
+    }
+  };
+
+  const controller = this.subject(model);
+
+  assert.equal(controller.get("totalPages"), 0);
 });