Skip to content

Resolving FIPS incompliance in gardener/landscaper: Usage of sha1.New() in ComputeImportsHash #106

@In-Ko

Description

@In-Ko

https://github.com/gardener/landscaper/blob/10013c483a60bd304716f02e621838ac1618dabd/pkg/landscaper/installations/imports/hash.go#L44

As far as I can see we are only using this to calculate import hashes to detect changes in these two instances

https://github.com/gardener/landscaper/blob/d224a75a09f17731c5be8d8937fda0ee1037c39b/pkg/landscaper/controllers/installations/reconcile.go#L288-L290
https://github.com/gardener/landscaper/blob/d224a75a09f17731c5be8d8937fda0ee1037c39b/pkg/landscaper/controllers/installations/reconcile.go#L525
⟹ so I think this should be easy enough to replace with a new hashing mechanism. Might even be that it's directly compatible with then old implementation: afaics it would just detect a change and re-deploy all components, but then they are using the new hash

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/open-mcpAll ManagedControlPlane related issues

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions