Skip to content

Resolving FIPS incompliance in gardener/landscaper: Usage of sha1.New() in generateHash #109

@In-Ko

Description

@In-Ko

https://github.com/gardener/landscaper/blob/10013c483a60bd304716f02e621838ac1618dabd/pkg/landscaper/dataobjects/dataobject.go#L53

  1. the error from h.Write is unhandled, which would swallow any type of FIPS failure
  2. I can see that the hashes generated from this function are often added to DataObjects, but I cannot really find the code where we do anything with these hashes. I can see all the way uptop we are using it to generate ImportHashes (https://github.com/gardener/landscaper/blob/d224a75a09f17731c5be8d8937fda0ee1037c39b/pkg/landscaper/controllers/installations/reconcile.go#L364), but I am wondering if there are two different code-paths to essentially achieve the same 🤔

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/open-mcpAll ManagedControlPlane related issues

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions