Skip to content

Commit 8f48416

Browse files
committed
fixes
1 parent 301d2b7 commit 8f48416

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

internal/deployment-repo/deploymentRepoManager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ func (m *DeploymentRepoManager) ApplyTemplates(ctx context.Context) error {
194194
logger.Infof("Applying templates from %s to deployment repository", m.TemplateResourceLocation)
195195

196196
templateInput := make(map[string]interface{})
197-
openMCPOperatorCV, err := m.compGetter.GetReferencedComponentVersion(ctx, openMCPOperatorComponentName)
197+
openMCPOperatorCV, err := m.compGetter.GetReferencedComponentVersion(ctx, m.compGetter.RootComponentVersion(), openMCPOperatorComponentName)
198198

199199
if err == nil {
200200
logger.Infof("Found openmcp-operator component version: %s:%s", openMCPOperatorCV.Component.Name, openMCPOperatorCV.Component.Version)

internal/deployment-repo/repo_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import (
55
"testing"
66

77
"github.com/go-git/go-git/v5"
8+
"github.com/stretchr/testify/assert"
9+
810
deploymentrepo "github.com/openmcp-project/bootstrapper/internal/deployment-repo"
911
gitconfig "github.com/openmcp-project/bootstrapper/internal/git-config"
1012
testutils "github.com/openmcp-project/bootstrapper/test/utils"
11-
"github.com/stretchr/testify/assert"
1213
)
1314

1415
func Test_Repo(t *testing.T) {

internal/deployment-repo/templater.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ type ProviderOptions struct {
124124
// TemplateProviders templates the specified cluster providers, service providers, and platform services
125125
func TemplateProviders(ctx context.Context, clusterProviders, serviceProviders, platformServices, imagePullSecrets []string, ocmGetter *ocmcli.ComponentGetter, repo *git.Repository) error {
126126
for _, cp := range clusterProviders {
127-
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, "cluster-provider-"+cp)
127+
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, ocmGetter.RootComponentVersion(), "cluster-provider-"+cp)
128128
if err != nil {
129129
return fmt.Errorf("failed to get component version for cluster provider %s: %w", cp, err)
130130
}
@@ -147,7 +147,7 @@ func TemplateProviders(ctx context.Context, clusterProviders, serviceProviders,
147147
}
148148

149149
for _, sp := range serviceProviders {
150-
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, "service-provider-"+sp)
150+
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, ocmGetter.RootComponentVersion(), "service-provider-"+sp)
151151
if err != nil {
152152
return fmt.Errorf("failed to get component version for service provider %s: %w", sp, err)
153153
}
@@ -170,7 +170,7 @@ func TemplateProviders(ctx context.Context, clusterProviders, serviceProviders,
170170
}
171171

172172
for _, ps := range platformServices {
173-
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, "platform-service-"+ps)
173+
componentVersion, err := ocmGetter.GetReferencedComponentVersion(ctx, ocmGetter.RootComponentVersion(), "platform-service-"+ps)
174174
if err != nil {
175175
return fmt.Errorf("failed to get component version for platform service %s: %w", ps, err)
176176
}

internal/deployment-repo/templater_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ import (
55
"testing"
66

77
"github.com/go-git/go-git/v5"
8+
"github.com/stretchr/testify/assert"
9+
"sigs.k8s.io/yaml"
10+
811
deploymentrepo "github.com/openmcp-project/bootstrapper/internal/deployment-repo"
912
ocmcli "github.com/openmcp-project/bootstrapper/internal/ocm-cli"
1013
testutils "github.com/openmcp-project/bootstrapper/test/utils"
11-
"github.com/stretchr/testify/assert"
12-
"sigs.k8s.io/yaml"
1314
)
1415

1516
func TestTemplateDir(t *testing.T) {
@@ -35,6 +36,7 @@ func TestTemplateDir(t *testing.T) {
3536
assert.Equal(t, "Hello, World!", templateResult)
3637

3738
workTree, err := repo.Worktree()
39+
assert.NoError(t, err)
3840
workTreeStatus, err := workTree.Status()
3941
assert.NoError(t, err)
4042
assert.False(t, workTreeStatus.IsClean())

internal/ocm-cli/component_getter.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func (g *ComponentGetter) InitializeComponents(ctx context.Context) error {
5454

5555
cv := g.rootComponentVersion
5656
for _, refName := range referenceNames {
57-
cv, err = g.GetReferencedComponentVersion(ctx, refName)
57+
cv, err = g.GetReferencedComponentVersion(ctx, cv, refName)
5858
if err != nil {
5959
return fmt.Errorf("error getting referenced component version %s: %w", refName, err)
6060
}
@@ -77,8 +77,8 @@ func (g *ComponentGetter) TemplatesResourceName() string {
7777
return g.templatesResourceName
7878
}
7979

80-
func (g *ComponentGetter) GetReferencedComponentVersion(ctx context.Context, refName string) (*ComponentVersion, error) {
81-
ref, err := g.rootComponentVersion.GetComponentReference(refName)
80+
func (g *ComponentGetter) GetReferencedComponentVersion(ctx context.Context, parentCV *ComponentVersion, refName string) (*ComponentVersion, error) {
81+
ref, err := parentCV.GetComponentReference(refName)
8282
if err != nil {
8383
return nil, fmt.Errorf("error getting component reference %s: %w", refName, err)
8484
}

0 commit comments

Comments
 (0)