feat: component getter tests

Author: robertgraeff

internal/ocm-cli/component_getter.go

@@ -69,6 +69,10 @@ func (g *ComponentGetter) TemplatesComponentVersion() *ComponentVersion {
 	return g.templatesComponentVersion
 }
 
+func (g *ComponentGetter) TemplatesResourceName() string {
+	return g.templatesResourceName
+}
+
 func getReferencedComponentVersion(ctx context.Context, repo string, parentCV *ComponentVersion, refName string, ocmConfig string) (*ComponentVersion, error) {
 	ref, err := parentCV.GetComponentReference(refName)
 	if err != nil {

internal/ocm-cli/component_getter_test.go

@@ -1,6 +1,7 @@
 package ocm_cli_test
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -11,23 +12,93 @@ import (
 
 func TestComponentGetter(t *testing.T) {
 	const (
-		rootComponentName      = "github.com/openmcp-project/openmcp"
+		componentA             = "github.com/openmcp-project/bootstrapper/test-component-getter-a"
+		componentB             = "github.com/openmcp-project/bootstrapper/test-component-getter-b"
+		componentC             = "github.com/openmcp-project/bootstrapper/test-component-getter-c"
+		version001             = "v0.0.1"
 		templatesComponentName = "github.com/openmcp-project/gitops-templates"
 	)
 
 	testutil.DownloadOCMAndAddToPath(t)
 	ctf := testutil.BuildComponent("./testdata/02/component-constructor.yaml", t)
-	rootLocation := ctf + "//github.com/openmcp-project/openmcp:v0.0.11"
-	g := ocmcli.NewComponentGetter(rootLocation, "gitops-templates/test-resource", ocmcli.NoOcmConfig)
 
-	err := g.InitializeComponents(t.Context())
-	assert.NoError(t, err, "Error initializing components")
+	testCases := []struct {
+		desc                           string
+		rootLocation                   string
+		deployTemplates                string
+		expectInitializationError      bool
+		expectedTemplatesComponentName string
+		expectResourceError            bool
+		expectedResourceName           string
+	}{
+		{
+			desc:                           "should get a resource of the root component",
+			rootLocation:                   fmt.Sprintf("%s//%s:%s", ctf, componentA, version001),
+			deployTemplates:                "test-resource-a",
+			expectedTemplatesComponentName: componentA,
+			expectedResourceName:           "test-resource-a",
+		},
+		{
+			desc:                           "should get a resource of a referenced component",
+			rootLocation:                   fmt.Sprintf("%s//%s:%s", ctf, componentA, version001),
+			deployTemplates:                "reference-b/test-resource-b",
+			expectedTemplatesComponentName: componentB,
+			expectedResourceName:           "test-resource-b",
+		},
+		{
+			desc:                           "should get a resource of a nested referenced component",
+			rootLocation:                   fmt.Sprintf("%s//%s:%s", ctf, componentA, version001),
+			deployTemplates:                "reference-b/reference-c/test-resource-c",
+			expectedTemplatesComponentName: componentC,
+			expectedResourceName:           "test-resource-c",
+		},
+		{
+			desc:                      "should fail for an unknown root component",
+			rootLocation:              fmt.Sprintf("%s//%s:%s", ctf, "unknown-component", version001),
+			deployTemplates:           "reference-b/test-resource-b",
+			expectInitializationError: true,
+		},
+		{
+			desc:                      "should fail for an unknown component reference",
+			rootLocation:              fmt.Sprintf("%s//%s:%s", ctf, componentA, version001),
+			deployTemplates:           "unknown-reference/test-resource-b",
+			expectInitializationError: true,
+		},
+		{
+			desc:                           "should fail for an unknown resource",
+			rootLocation:                   fmt.Sprintf("%s//%s:%s", ctf, componentA, version001),
+			deployTemplates:                "reference-b/unknown-resource",
+			expectedTemplatesComponentName: componentB,
+			expectResourceError:            true,
+		},
+	}
 
-	rootComponentVersion := g.RootComponentVersion()
-	assert.NotNil(t, rootComponentVersion, "Root component version should not be nil")
-	assert.Equal(t, rootComponentName, rootComponentVersion.Component.Name, "Root component name should match")
+	for _, tc := range testCases {
+		t.Run(tc.desc, func(t *testing.T) {
+			g := ocmcli.NewComponentGetter(tc.rootLocation, tc.deployTemplates, ocmcli.NoOcmConfig)
 
-	templatesComponentVersion := g.TemplatesComponentVersion()
-	assert.NotNil(t, templatesComponentVersion, "Templates component version should not be nil")
-	assert.Equal(t, templatesComponentName, templatesComponentVersion.Component.Name, "Templates component name should match")
+			err := g.InitializeComponents(t.Context())
+			if tc.expectInitializationError {
+				assert.Error(t, err, "Expected an error initializing components")
+				return
+			}
+			assert.NoError(t, err, "Error initializing components")
+
+			rootComponentVersion := g.RootComponentVersion()
+			assert.NotNil(t, rootComponentVersion, "Root component version should not be nil")
+			assert.Equal(t, componentA, rootComponentVersion.Component.Name, "Root component name should match")
+
+			templatesComponentVersion := g.TemplatesComponentVersion()
+			assert.NotNil(t, templatesComponentVersion, "Templates component version should not be nil")
+			assert.Equal(t, tc.expectedTemplatesComponentName, templatesComponentVersion.Component.Name, "Templates component name should match")
+
+			resource, err := templatesComponentVersion.GetResource(g.TemplatesResourceName())
+			if tc.expectResourceError {
+				assert.Error(t, err, "Expected an error getting resource")
+				return
+			}
+			assert.NoError(t, err, "Error getting resource")
+			assert.Equal(t, tc.expectedResourceName, resource.Name, "Resource name should match")
+		})
+	}
 }

internal/ocm-cli/testdata/02/component-constructor.yaml

@@ -1,26 +1,41 @@
 components:
 
-  - name: github.com/openmcp-project/openmcp
-    version: v0.0.11
+  - name: github.com/openmcp-project/bootstrapper/test-component-getter-a
+    version: v0.0.1
+    provider:
+      name: openmcp-project
+    componentReferences:
+      - componentName: github.com/openmcp-project/bootstrapper/test-component-getter-b
+        name: reference-b
+        version: v0.0.1
+    resources:
+      - name: test-resource-a
+        type: blob
+        input:
+          type: file
+          path: ./test-resource.yaml
+
+  - name: github.com/openmcp-project/bootstrapper/test-component-getter-b
+    version: v0.0.1
     provider:
       name: openmcp-project
     componentReferences:
-      - componentName: github.com/openmcp-project/gitops-templates
-        name: gitops-templates
+      - componentName: github.com/openmcp-project/bootstrapper/test-component-getter-c
+        name: reference-c
         version: v0.0.1
     resources:
-      - name: test-resource
+      - name: test-resource-b
         type: blob
         input:
           type: file
           path: ./test-resource.yaml
 
-  - name: github.com/openmcp-project/gitops-templates
+  - name: github.com/openmcp-project/bootstrapper/test-component-getter-c
     version: v0.0.1
     provider:
       name: openmcp-project
     resources:
-      - name: test-resource
+      - name: test-resource-c
         type: blob
         input:
           type: file